From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Suanming Mou <suanmingm@nvidia.com>, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] ethdev: add TCP/IP modify field IDs
Date: Tue, 10 Oct 2023 11:24:06 +0100 [thread overview]
Message-ID: <a23442dc-1206-4713-9e96-833ff107dfa3@amd.com> (raw)
In-Reply-To: <20230908034941.66782-1-suanmingm@nvidia.com>
On 9/8/2023 4:49 AM, Suanming Mou wrote:
> Currently, get TCP/IP header or data length information from traffic
> is missing in the modify field IDs. This commit adds the missing
> TCP data_offset, IPv4 IHL/total_len, IPv6 payload_len to modify filed
> IDs. This allows users be able to manager more TCP/IP fields.
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> ---
>
> v2: fix typo tcp_date_off -> tcp_data_off
>
> ---
> app/test-pmd/cmdline_flow.c | 1 +
> lib/ethdev/rte_flow.h | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 94827bcc4a..310068ce88 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -937,6 +937,7 @@ static const char *const modify_field_ids[] = {
> "flex_item",
> "hash_result",
> "geneve_opt_type", "geneve_opt_class", "geneve_opt_data", "mpls",
> + "tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len",
> NULL
> };
>
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 2ebb76dbc0..43ba51da6e 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -3875,6 +3875,10 @@ enum rte_flow_field_id {
> RTE_FLOW_FIELD_GENEVE_OPT_CLASS,/**< GENEVE option class. */
> RTE_FLOW_FIELD_GENEVE_OPT_DATA, /**< GENEVE option data. */
> RTE_FLOW_FIELD_MPLS, /**< MPLS header. */
> + RTE_FLOW_FIELD_TCP_DATA_OFFSET, /**< TCP data offset. */
> + RTE_FLOW_FIELD_IPV4_IHL, /**< IPv4 IHL. */
> + RTE_FLOW_FIELD_IPV4_TOTAL_LEN, /**< IPv4 total length. */
> + RTE_FLOW_FIELD_IPV6_PAYLOAD_LEN /**< IPv6 payload length. */
> };
>
> /**
Hi Suanming,
Patch looks good. But, testpmd modify flow action support seems not
documented at all, can you please first add it [1], later update that
document with this patch?
Also can you please check if `rte_flow.rst` also needs to be updated or not?
[1]: `doc/guides/testpmd_app_ug/testpmd_funcs.rst`, `Flow rules
management` section
next prev parent reply other threads:[~2023-10-10 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 8:37 [PATCH] " Suanming Mou
2023-09-08 3:49 ` [PATCH v2] " Suanming Mou
2023-10-10 10:24 ` Ferruh Yigit [this message]
2023-10-11 0:11 ` Suanming Mou
2023-10-11 8:58 ` Suanming Mou
2023-10-11 11:30 ` [PATCH v3 1/2] doc: add modify_field action description Suanming Mou
2023-10-11 11:30 ` [PATCH v3 2/2] ethdev: add TCP/IP modify field IDs Suanming Mou
2023-10-12 14:17 ` [PATCH v3 1/2] doc: add modify_field action description Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a23442dc-1206-4713-9e96-833ff107dfa3@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).