From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap
Date: Wed, 13 Sep 2017 09:27:17 +0300 [thread overview]
Message-ID: <a309f359-23ec-693d-5f88-c7761b2ea76e@solarflare.com> (raw)
In-Reply-To: <20170912145157.0794e9f7@plumbers-lap.home.lan>
On 09/13/2017 12:51 AM, Stephen Hemminger wrote:
> On Fri, 8 Sep 2017 15:15:50 +0100
> Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
>> + txd->mbuf = NULL;
>> + if (m == NULL)
>> + continue;
>> +
>> + if ((nb == RTE_DIM(bulk)) ||
>> + ((nb != 0) && (m->pool != bulk[0]->pool))) {
>> + rte_mempool_put_bulk(bulk[0]->pool,
>> + (void *)bulk, nb);
>> + nb = 0;
>> }
>> +
> Why not add rte_mbuf_free_bulk (inline) to base code, rather than recoding
> everywhere?
I'm not 100% sure that I understand the question in a right way, but if
you're
talking about base driver code, it is not used in native datapath
implementations
at all (just header files with HW/SW interface definition). In fact
patches 1 and 2
of the series are slightly different and the difference is proved by
performance
measurements.
next prev parent reply other threads:[~2017-09-13 6:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 14:15 Andrew Rybchenko
2017-09-08 14:15 ` [dpdk-dev] [PATCH 2/2] net/sfc: free mbufs in bulks on simple EF10 " Andrew Rybchenko
2017-09-12 18:28 ` Ferruh Yigit
2017-09-13 9:32 ` Andrew Rybchenko
2017-09-12 18:26 ` [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native " Ferruh Yigit
2017-09-13 9:31 ` Andrew Rybchenko
2017-09-12 21:51 ` Stephen Hemminger
2017-09-13 6:27 ` Andrew Rybchenko [this message]
2017-09-13 9:33 ` [dpdk-dev] [PATCH v2 " Andrew Rybchenko
2017-09-13 9:33 ` [dpdk-dev] [PATCH v2 2/2] net/sfc: free mbufs in bulks on simple EF10 " Andrew Rybchenko
2017-09-15 11:12 ` [dpdk-dev] [PATCH v2 1/2] net/sfc: free mbufs in bulks on EF10 native " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a309f359-23ec-693d-5f88-c7761b2ea76e@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).