From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Allain Legacy <allain.legacy@windriver.com>
Cc: dev@dpdk.org, ian.jolliffe@windriver.com,
bruce.richardson@intel.com, john.mcnamara@intel.com,
keith.wiles@intel.com, thomas.monjalon@6wind.com,
vincent.jardin@6wind.com, jerin.jacob@caviumnetworks.com,
stephen@networkplumber.org, 3chas3@gmail.com, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 00/14] Wind River Systems AVP PMD
Date: Thu, 23 Mar 2017 14:18:28 +0000 [thread overview]
Message-ID: <a40ed900-17e6-0415-3b26-a444f22a1a26@intel.com> (raw)
In-Reply-To: <20170323112413.175202-1-allain.legacy@windriver.com>
On 3/23/2017 11:23 AM, Allain Legacy wrote:
> This patch series submits an initial version of the AVP PMD from Wind River
> Systems. The series includes shared header files, driver implementation,
> and changes to documentation files in support of this new driver. The AVP
> driver is a shared memory based device. It is intended to be used as a PMD
> within a virtual machine running on a Wind River virtualization platform.
> See: http://www.windriver.com/products/titanium-cloud/
>
> It enables optimized packet throughput without requiring any packet
> processing in qemu. This allowed us to provide our customers with a
> significant performance increase for both DPDK and non-DPDK applications
> in the VM. Since our AVP implementation supports VM live-migration it
> is viewed as a better alternative to PCI passthrough or PCI SRIOV since
> neither of those support VM live-migration without manual intervention
> or significant performance penalties.
>
> Since the initial implementation of AVP devices, vhost-user has become part
> of the qemu offering with a significant performance increase over the
> original virtio implementation. However, vhost-user still does not achieve
> the level of performance that the AVP device can provide to our customers
> for DPDK based guests.
>
> A number of our customers have requested that we upstream the driver to
> dpdk.org.
>
> v2:
> * Fixed coding style violations that slipped in accidentally because of an
> out of date checkpatch.pl from an older kernel.
>
> v3:
> * Updated 17.05 release notes to add a section for this new PMD
> * Added additional info to the AVP nic guide document to clarify the
> benefit of using AVP over virtio.
> * Fixed spelling error in debug log missed by local checkpatch.pl version
> * Split the transmit patch to separate the stats functions as they
> accidentally got squashed in the last patchset.
> * Fixed debug log strings so that they exceed 80 characters rather than
> span multiple lines.
> * Renamed RTE_AVP_* defines that were in avp_ethdev.h to be AVP_* instead
> * Replaced usage of RTE_WRITE32 and RTE_READ32 with rte_write32_relaxed
> and rte_read32_relaxed.
> * Declared rte_pci_id table as const
>
> v4:
> * Split our interrupt handlers to a separate patch and moved to the end
> of the series.
> * Removed memset() from stats_get API
> * Removed usage of RTE_AVP_ALIGNMENT
> * Removed unnecessary parentheses in rte_avp_common.h
> * Removed unneeded "goto unlock" where there are no statements in between
> the goto and the end of the function.
> * Re-tested with pktgen and found that rte_eth_tx_burst() is being called
> with 0 packets even before starting traffic which resulted in
> incrementing oerrors; fixed in transmit patch.
>
> v5:
> * Updated documentation to remove references to ivshmem as it lead to
> confusion about whether AVP is exactly like ivshmem or simply based on
> how ivshmem exports memory to a VM via a PCI device.
> * Restructured first set of patches to condense them down to a base patch
> with the files needed to apply subsequent patches.
> * Removed static prototypes from init/uninit functions in avp_ethdev.c
> * Moved MAC addresses init to the device initialization patch because it
> is setup by the avp_dev_create() function.
> * Split the changes to the avp.ini features file so that features are
> marked as enabled in the patch that actually enables them.
>
> Allain Legacy (14):
> drivers/net: adds AVP PMD base files
> net/avp: public header files
> net/avp: debug log macros
> net/avp: driver registration
> net/avp: device initialization
> net/avp: device configuration
> net/avp: queue setup and release
> net/avp: packet receive functions
> net/avp: packet transmit functions
> net/avp: device statistics operations
> net/avp: device promiscuous functions
> net/avp: device start and stop operations
> net/avp: migration interrupt handling
> doc: adds information related to the AVP PMD
Hi Allain,
Overall PMD looks good to me.
Only can you please update documentation based on tech board decision [1].
Repeating related part here:
"
It should be clearly stated that right now AVP PMD is limited to use
with WindRiver hypervisor and for most cases virtio is still a preferred
virtual device to use with QEMU.
"
Thanks,
ferruh
[1]
http://dpdk.org/ml/archives/dev/2017-March/061009.html
next prev parent reply other threads:[~2017-03-23 14:18 UTC|newest]
Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 1:22 [dpdk-dev] [PATCH 00/16] " Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 01/16] config: adds attributes for the " Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 02/16] net/avp: public header files Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 03/16] maintainers: claim responsibility for AVP PMD Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 04/16] net/avp: add PMD version map file Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 05/16] net/avp: debug log macros Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 06/16] drivers/net: adds driver makefiles for AVP PMD Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 07/16] net/avp: driver registration Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 08/16] net/avp: device initialization Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 09/16] net/avp: device configuration Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 10/16] net/avp: queue setup and release Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 11/16] net/avp: packet receive functions Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 12/16] net/avp: packet transmit functions Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 13/16] net/avp: device statistics operations Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 14/16] net/avp: device promiscuous functions Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 15/16] net/avp: device start and stop operations Allain Legacy
2017-02-25 1:23 ` [dpdk-dev] [PATCH 16/16] doc: adds information related to the AVP PMD Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 00/16] Wind River Systems " Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 01/15] config: adds attributes for the " Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 02/15] net/avp: public header files Allain Legacy
2017-02-28 11:49 ` Jerin Jacob
2017-03-01 13:25 ` Legacy, Allain
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 03/15] maintainers: claim responsibility for AVP PMD Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 04/15] net/avp: add PMD version map file Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 05/15] net/avp: debug log macros Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 06/15] drivers/net: adds driver makefiles for AVP PMD Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 07/15] net/avp: driver registration Allain Legacy
2017-02-27 16:47 ` Stephen Hemminger
2017-02-27 17:10 ` Legacy, Allain
2017-02-27 16:53 ` Stephen Hemminger
2017-02-27 17:09 ` Legacy, Allain
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 08/15] net/avp: device initialization Allain Legacy
2017-02-28 11:57 ` Jerin Jacob
2017-03-01 13:29 ` Legacy, Allain
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 09/15] net/avp: device configuration Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 10/15] net/avp: queue setup and release Allain Legacy
2017-02-26 19:08 ` [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions Allain Legacy
2017-02-27 16:46 ` Stephen Hemminger
2017-02-27 17:06 ` Legacy, Allain
2017-02-28 10:27 ` Bruce Richardson
2017-03-01 13:23 ` Legacy, Allain
2017-03-01 14:14 ` Thomas Monjalon
2017-03-01 14:54 ` Legacy, Allain
2017-03-01 15:10 ` Stephen Hemminger
2017-03-01 15:40 ` Legacy, Allain
2017-02-26 19:09 ` [dpdk-dev] [PATCH v2 12/15] net/avp: packet transmit functions Allain Legacy
2017-02-26 22:18 ` Legacy, Allain
2017-02-26 19:09 ` [dpdk-dev] [PATCH v2 13/15] net/avp: device promiscuous functions Allain Legacy
2017-02-26 19:09 ` [dpdk-dev] [PATCH v2 14/15] net/avp: device start and stop operations Allain Legacy
2017-02-26 19:09 ` [dpdk-dev] [PATCH v2 15/15] doc: adds information related to the AVP PMD Allain Legacy
2017-02-27 17:04 ` Mcnamara, John
2017-02-27 17:07 ` Legacy, Allain
2017-02-27 8:54 ` [dpdk-dev] [PATCH v2 00/16] Wind River Systems " Vincent JARDIN
2017-02-27 12:15 ` Legacy, Allain
2017-02-27 15:17 ` Wiles, Keith
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 " Allain Legacy
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 01/16] config: adds attributes for the " Allain Legacy
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 02/16] net/avp: public header files Allain Legacy
2017-03-03 14:37 ` Chas Williams
2017-03-03 15:35 ` Legacy, Allain
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 03/16] maintainers: claim responsibility for AVP PMD Allain Legacy
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 04/16] net/avp: add PMD version map file Allain Legacy
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 05/16] net/avp: debug log macros Allain Legacy
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 06/16] drivers/net: adds driver makefiles for AVP PMD Allain Legacy
2017-03-02 0:19 ` [dpdk-dev] [PATCH v3 07/16] net/avp: driver registration Allain Legacy
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization Allain Legacy
2017-03-03 15:04 ` Chas Williams
2017-03-09 14:03 ` Legacy, Allain
2017-03-09 14:48 ` Legacy, Allain
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 09/16] net/avp: device configuration Allain Legacy
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 10/16] net/avp: queue setup and release Allain Legacy
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 11/16] net/avp: packet receive functions Allain Legacy
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 12/16] net/avp: packet transmit functions Allain Legacy
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 13/16] net/avp: device statistics operations Allain Legacy
2017-03-02 0:35 ` Stephen Hemminger
2017-03-09 13:48 ` Legacy, Allain
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 14/16] net/avp: device promiscuous functions Allain Legacy
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 15/16] net/avp: device start and stop operations Allain Legacy
2017-03-02 0:37 ` Stephen Hemminger
2017-03-09 13:49 ` Legacy, Allain
2017-03-02 0:20 ` [dpdk-dev] [PATCH v3 16/16] doc: adds information related to the AVP PMD Allain Legacy
2017-03-03 16:21 ` Vincent JARDIN
2017-03-13 19:17 ` Legacy, Allain
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 00/17] Wind River Systems " Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 01/17] config: adds attributes for the " Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 02/17] net/avp: public header files Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 03/17] maintainers: claim responsibility for AVP PMD Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 04/17] net/avp: add PMD version map file Allain Legacy
2017-03-16 14:52 ` Ferruh Yigit
2017-03-16 15:33 ` Legacy, Allain
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 05/17] net/avp: debug log macros Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 06/17] drivers/net: adds driver makefiles for AVP PMD Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 07/17] net/avp: driver registration Allain Legacy
2017-03-16 14:53 ` Ferruh Yigit
2017-03-16 15:37 ` Legacy, Allain
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 08/17] net/avp: device initialization Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 09/17] net/avp: device configuration Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 10/17] net/avp: queue setup and release Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 11/17] net/avp: packet receive functions Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 12/17] net/avp: packet transmit functions Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 13/17] net/avp: device statistics operations Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 14/17] net/avp: device promiscuous functions Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 15/17] net/avp: device start and stop operations Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 16/17] net/avp: migration interrupt handling Allain Legacy
2017-03-13 19:16 ` [dpdk-dev] [PATCH v4 17/17] doc: adds information related to the AVP PMD Allain Legacy
2017-03-16 14:53 ` Ferruh Yigit
2017-03-16 15:37 ` Legacy, Allain
2017-03-14 17:37 ` [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? Vincent JARDIN
2017-03-15 4:10 ` O'Driscoll, Tim
2017-03-15 10:55 ` Thomas Monjalon
2017-03-15 14:02 ` Vincent JARDIN
2017-03-16 3:18 ` O'Driscoll, Tim
2017-03-16 8:52 ` Francois Ozog
2017-03-16 9:51 ` Wiles, Keith
2017-03-16 10:32 ` Chas Williams
2017-03-16 18:09 ` Francois Ozog
2017-03-15 11:29 ` Ferruh Yigit
2017-03-15 14:08 ` Vincent JARDIN
2017-03-15 18:18 ` Ferruh Yigit
2017-03-15 14:02 ` Vincent JARDIN
2017-03-15 14:02 ` Vincent JARDIN
2017-03-15 20:19 ` Wiles, Keith
2017-03-16 23:17 ` Stephen Hemminger
2017-03-16 23:41 ` [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back Vincent JARDIN
2017-03-17 0:08 ` Wiles, Keith
2017-03-17 0:15 ` O'Driscoll, Tim
2017-03-17 0:11 ` Wiles, Keith
2017-03-17 0:14 ` Stephen Hemminger
2017-03-17 0:31 ` Vincent JARDIN
2017-03-17 0:53 ` Wiles, Keith
2017-03-17 8:48 ` Thomas Monjalon
2017-03-17 10:15 ` Legacy, Allain
2017-03-17 13:52 ` Michael S. Tsirkin
2017-03-20 22:30 ` Hobywan Kenoby
2017-03-21 11:06 ` Thomas Monjalon
[not found] ` <20170317093320.GA11116@stefanha-x1.localdomain>
2017-03-30 8:55 ` Markus Armbruster
2017-03-23 11:23 ` [dpdk-dev] [PATCH v5 00/14] Wind River Systems AVP PMD Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 01/14] drivers/net: adds AVP PMD base files Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 02/14] net/avp: public header files Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 03/14] net/avp: debug log macros Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 04/14] net/avp: driver registration Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 05/14] net/avp: device initialization Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 06/14] net/avp: device configuration Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 07/14] net/avp: queue setup and release Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 08/14] net/avp: packet receive functions Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 09/14] net/avp: packet transmit functions Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 10/14] net/avp: device statistics operations Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 11/14] net/avp: device promiscuous functions Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 12/14] net/avp: device start and stop operations Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 13/14] net/avp: migration interrupt handling Allain Legacy
2017-03-23 11:24 ` [dpdk-dev] [PATCH v5 14/14] doc: adds information related to the AVP PMD Allain Legacy
2017-03-23 14:18 ` Ferruh Yigit [this message]
2017-03-23 18:28 ` [dpdk-dev] [PATCH v5 00/14] Wind River Systems " Legacy, Allain
2017-03-23 20:35 ` Vincent Jardin
2017-03-28 11:53 ` [dpdk-dev] [PATCH v6 " Allain Legacy
2017-03-28 11:53 ` [dpdk-dev] [PATCH v6 01/14] drivers/net: adds AVP PMD base files Allain Legacy
2017-03-28 11:53 ` [dpdk-dev] [PATCH v6 02/14] net/avp: public header files Allain Legacy
2017-03-28 11:53 ` [dpdk-dev] [PATCH v6 03/14] net/avp: debug log macros Allain Legacy
2017-03-28 11:53 ` [dpdk-dev] [PATCH v6 04/14] net/avp: driver registration Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 05/14] net/avp: device initialization Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 06/14] net/avp: device configuration Allain Legacy
2017-03-29 10:28 ` Ferruh Yigit
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 07/14] net/avp: queue setup and release Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 08/14] net/avp: packet receive functions Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 09/14] net/avp: packet transmit functions Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 10/14] net/avp: device statistics operations Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 11/14] net/avp: device promiscuous functions Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 12/14] net/avp: device start and stop operations Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 13/14] net/avp: migration interrupt handling Allain Legacy
2017-03-28 11:54 ` [dpdk-dev] [PATCH v6 14/14] doc: adds information related to the AVP PMD Allain Legacy
2017-03-29 10:44 ` [dpdk-dev] [PATCH v6 00/14] Wind River Systems " Vincent JARDIN
2017-03-29 11:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a40ed900-17e6-0415-3b26-a444f22a1a26@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=allain.legacy@windriver.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ian.jolliffe@windriver.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
--cc=vincent.jardin@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).