From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Rahul Bhansali <rbhansali@marvell.com>,
dev@dpdk.org, Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [PATCH] examples/ipsec-secgw: fix IPsec performance drop
Date: Tue, 6 Feb 2024 18:25:20 +0000 [thread overview]
Message-ID: <a4199729-3071-4e64-a36c-4cc9fd8becaf@amd.com> (raw)
In-Reply-To: <20240206123811.3452587-1-rbhansali@marvell.com>
On 2/6/2024 12:38 PM, Rahul Bhansali wrote:
> Single packet free using rte_pktmbuf_free_bulk() is dropping the
> performance. On cn10k, maximum of ~4% drop observed for IPsec
> event mode single SA outbound case.
>
> To fix this issue, single packet free will use rte_pktmbuf_free
> API.
>
> Fixes: bd7c063561b3 ("examples/ipsec-secgw: use bulk free")
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> ---
> examples/ipsec-secgw/ipsec-secgw.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/examples/ipsec-secgw/ipsec-secgw.h b/examples/ipsec-secgw/ipsec-secgw.h
> index 8baab44ee7..ec33a982df 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.h
> +++ b/examples/ipsec-secgw/ipsec-secgw.h
> @@ -229,11 +229,10 @@ free_reassembly_fail_pkt(struct rte_mbuf *mb)
> }
>
> /* helper routine to free bulk of packets */
> -static inline void
> -free_pkts(struct rte_mbuf *mb[], uint32_t n)
> +static __rte_always_inline void
> +free_pkts(struct rte_mbuf *mb[], const uint32_t n)
> {
> - rte_pktmbuf_free_bulk(mb, n);
> -
> + n == 1 ? rte_pktmbuf_free(mb[0]) : rte_pktmbuf_free_bulk(mb, n);
> core_stats_update_drop(n);
> }
>
Hi Rahul,
Do you think the 'rte_pktmbuf_free_bulk()' API performance can be
improved by similar change?
next prev parent reply other threads:[~2024-02-06 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 12:38 Rahul Bhansali
2024-02-06 18:25 ` Ferruh Yigit [this message]
2024-02-07 6:46 ` [EXT] " Rahul Bhansali
2024-02-07 10:35 ` Ferruh Yigit
2024-02-09 13:10 ` Rahul Bhansali
2024-02-09 13:51 ` Ferruh Yigit
2024-02-13 12:50 ` Rahul Bhansali
2024-02-29 17:06 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4199729-3071-4e64-a36c-4cc9fd8becaf@amd.com \
--to=ferruh.yigit@amd.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=konstantin.ananyev@huawei.com \
--cc=radu.nicolau@intel.com \
--cc=rbhansali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).