From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/6] net: ngbe PMD
Date: Thu, 29 Apr 2021 12:21:11 +0100 [thread overview]
Message-ID: <a436ff20-403c-3026-7f10-b90f0730082d@intel.com> (raw)
In-Reply-To: <009f01d73ce5$bc3694f0$34a3bed0$@trustnetic.com>
On 4/29/2021 11:52 AM, Jiawen Wu wrote:
> On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote:
>> On 4/6/2021 10:30 AM, Jiawen Wu wrote:
>>> This patch set provides a skeleton of ngbe PMD, which adapted to
>>> Wangxun WX1860 series NICs.
>>>
>>> v4:
>>> - Fix compile error.
>>>
>>> v3:
>>> - Use rte_ether functions to define marcos.
>>>
>>> v2:
>>> - Correct some clerical errors.
>>> - Use ethdev debug flags instead of driver own.
>>>
>>> Jiawen Wu (6):
>>> net/ngbe: add build and doc infrastructure
>>> net/ngbe: add device IDs
>>> net/ngbe: support probe and remove
>>> net/ngbe: add device init and uninit
>>> net/ngbe: add log type and error type
>>> net/ngbe: define registers
>>>
>>
>> Hi Jiawen,
>>
>> I put some comments on some patches, but as far as I can see the device is not
>> functional yet after this set, I assume rest of the support will be submitted
>> later.
>> But I think the device should have at least bare minimum functionality when it
>> is upstreamed, like proper device initialization and primitive Rx/Tx, also it would
>> be good to have basic control functions.
>> More control and datapath functionality can be added gradually later.
>>
>> What do you think extending this set to have base minimum functionality?
>>
>> Thanks,
>> ferruh
>
> Hi Ferruh,
>
> Unfortunately, this driver may not be merged in 21.05, to follow the roadmap.
> There is not enough time for me to improve the patches, because I was busy with other works in these weeks.
>
> I'll try my best to submit the driver in this release cycle, and hope it will be merged nicely in next release.
>
That is OK, thanks for heads up.
prev parent reply other threads:[~2021-04-29 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 9:30 Jiawen Wu
2021-04-06 9:30 ` [dpdk-dev] [PATCH v4 1/6] net/ngbe: add build and doc infrastructure Jiawen Wu
2021-04-09 14:37 ` Ferruh Yigit
2021-04-12 6:33 ` Jiawen Wu
2021-04-06 9:30 ` [dpdk-dev] [PATCH v4 2/6] net/ngbe: add device IDs Jiawen Wu
2021-04-09 14:37 ` Ferruh Yigit
2021-04-06 9:30 ` [dpdk-dev] [PATCH v4 3/6] net/ngbe: support probe and remove Jiawen Wu
2021-04-09 14:40 ` Ferruh Yigit
2021-04-06 9:30 ` [dpdk-dev] [PATCH v4 4/6] net/ngbe: add device init and uninit Jiawen Wu
2021-04-06 9:30 ` [dpdk-dev] [PATCH v4 5/6] net/ngbe: add log type and error type Jiawen Wu
2021-04-06 9:30 ` [dpdk-dev] [PATCH v4 6/6] net/ngbe: define registers Jiawen Wu
2021-04-09 14:47 ` [dpdk-dev] [PATCH v4 0/6] net: ngbe PMD Ferruh Yigit
2021-04-29 10:52 ` Jiawen Wu
2021-04-29 11:21 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a436ff20-403c-3026-7f10-b90f0730082d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).