From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4] tap: do not duplicate fd's
Date: Thu, 25 Apr 2024 13:50:42 +0100 [thread overview]
Message-ID: <a45ca7e4-5d61-4d57-9a04-a3db6c3bbd55@amd.com> (raw)
In-Reply-To: <20240424120459.61030d5c@hermes.local>
On 4/24/2024 8:04 PM, Stephen Hemminger wrote:
> On Wed, 24 Apr 2024 17:57:46 +0100
> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
>> OK to merge file descriptors instead of duplicating them.
>>
>> But we have this 4 queue limitation only for multi process case, right?
>> If user is planning to use only with primary, this will reduce the
>> supported queue number.
>>
>> Does it make sense to enforce this limitation for secondary only and
>> keep TAP_MAX_QUEUES same?
>> So for multi process usecase supported queue number will be 8, for
>> primary only use case it will remain 16.
>>
>> <...>
>
> Yes, the lower limit only applies to the secondary process.
> But any application using secondary processes will have the problem;
> i.e it is not that primary gets 16 and the secondary only sees 8.
>
> Lets keep MAX_QUEUES at 16 for now, and let users see the warning.
> For 24.11 up the max passed fd's to what Linux allows.
>
+1
prev parent reply other threads:[~2024-04-25 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0240308185401.150651-1-stephen@networkplumber.org>
2024-03-11 19:45 ` Stephen Hemminger
2024-04-24 16:57 ` Ferruh Yigit
2024-04-24 19:04 ` Stephen Hemminger
2024-04-25 12:50 ` Ferruh Yigit
2024-04-25 12:50 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a45ca7e4-5d61-4d57-9a04-a3db6c3bbd55@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).