From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jie Hai <haijie1@huawei.com>, dev@dpdk.org
Subject: Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code
Date: Thu, 9 Nov 2023 18:50:39 +0000 [thread overview]
Message-ID: <a466f938-7361-4c2e-9134-ede8da57f2fe@amd.com> (raw)
In-Reply-To: <20231108034434.559030-1-haijie1@huawei.com>
On 11/8/2023 3:44 AM, Jie Hai wrote:
> This patchset fixes failure on sync mailbox and refactors some codes on mailbox.
>
> Dengdui Huang (5):
> net/hns3: fix sync mailbox failure forever
> net/hns3: refactor VF mailbox message struct
> net/hns3: refactor PF mailbox message struct
> net/hns3: refactor send mailbox function
> net/hns3: refactor handle mailbox function
>
Hi Jie,
Overall patchset looks good with minor issue below [1], but this set has
high impact and not solving a critical defect etc, but mainly refactoring.
We are very close to the release, there won't be enough time to fix any
issue caused by this refactoring.
My suggestion is to postpone the refactoring to next release, maybe get
only the first fix patch in this release, what do you think?
[1]
Can you please fix the checkpatch warning:
### [PATCH] net/hns3: refactor handle mailbox function
Warning in drivers/net/hns3/hns3_mbx.c:
Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer
rte_atomic_xxx/rte_memory_order_xxx
next prev parent reply other threads:[~2023-11-09 18:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 3:44 Jie Hai
2023-11-08 3:44 ` [PATCH 1/5] net/hns3: fix sync mailbox failure forever Jie Hai
2023-11-08 3:44 ` [PATCH 2/5] net/hns3: refactor VF mailbox message struct Jie Hai
2023-11-09 18:51 ` Ferruh Yigit
2023-11-08 3:44 ` [PATCH 3/5] net/hns3: refactor PF " Jie Hai
2023-11-08 3:44 ` [PATCH 4/5] net/hns3: refactor send mailbox function Jie Hai
2023-11-08 3:44 ` [PATCH 5/5] net/hns3: refactor handle " Jie Hai
2023-11-09 18:50 ` Ferruh Yigit [this message]
2023-11-10 6:21 ` [PATCH 0/5] net/hns3: fix and refactor mailbox code Jie Hai
2023-11-10 12:35 ` Ferruh Yigit
2023-11-10 6:13 ` [PATCH v2 0/6] net/hns3: fix and refactor some codes Jie Hai
2023-11-10 6:13 ` [PATCH v2 1/6] net/hns3: fix sync mailbox failure forever Jie Hai
2023-11-10 6:13 ` [PATCH v2 2/6] net/hns3: use stdatomic API Jie Hai
2023-11-10 6:13 ` [PATCH v2 3/6] net/hns3: refactor VF mailbox message struct Jie Hai
2023-11-10 6:13 ` [PATCH v2 4/6] net/hns3: refactor PF " Jie Hai
2023-11-10 6:13 ` [PATCH v2 5/6] net/hns3: refactor send mailbox function Jie Hai
2023-11-10 16:23 ` Ferruh Yigit
2023-11-10 6:13 ` [PATCH v2 6/6] net/hns3: refactor handle " Jie Hai
2023-11-10 16:12 ` [PATCH v2 0/6] net/hns3: fix and refactor some codes Ferruh Yigit
2023-12-07 1:37 ` [PATCH v3 0/4] net/hns3: refactor mailbox Jie Hai
2023-12-07 1:37 ` [PATCH v3 1/4] net/hns3: refactor VF mailbox message struct Jie Hai
2023-12-07 12:47 ` Ferruh Yigit
2023-12-07 1:37 ` [PATCH v3 2/4] net/hns3: refactor PF " Jie Hai
2023-12-07 1:37 ` [PATCH v3 3/4] net/hns3: refactor send mailbox function Jie Hai
2023-12-07 1:37 ` [PATCH v3 4/4] net/hns3: refactor handle " Jie Hai
2023-12-07 12:31 ` [PATCH v3 0/4] net/hns3: refactor mailbox Ferruh Yigit
2023-12-08 1:06 ` Jie Hai
2023-12-08 6:55 ` [PATCH v4 " Jie Hai
2023-12-08 6:55 ` [PATCH v4 1/4] net/hns3: refactor VF mailbox message struct Jie Hai
2023-12-08 6:55 ` [PATCH v4 2/4] net/hns3: refactor PF " Jie Hai
2023-12-08 6:55 ` [PATCH v4 3/4] net/hns3: refactor send mailbox function Jie Hai
2023-12-08 6:55 ` [PATCH v4 4/4] net/hns3: refactor handle " Jie Hai
2023-12-08 10:48 ` [PATCH v4 0/4] net/hns3: refactor mailbox Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a466f938-7361-4c2e-9134-ede8da57f2fe@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=haijie1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).