From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Patrick Fu <patrick.fu@intel.com>, dev@dpdk.org, chenbo.xia@intel.com
Subject: Re: [dpdk-dev] [PATCH v5] vhost: fix async copy fail on multi-page buffers
Date: Wed, 29 Jul 2020 16:24:53 +0200 [thread overview]
Message-ID: <a48c6a8e-914f-9bd7-d122-7ef5de315a7a@redhat.com> (raw)
In-Reply-To: <20200729020456.3741118-1-patrick.fu@intel.com>
On 7/29/20 4:04 AM, Patrick Fu wrote:
> Async copy fails when single ring buffer vector is splited on multiple
> physical pages. This happens because current hpa address translation
> function doesn't handle multi-page buffers. A new gpa to hpa address
> conversion function, which returns the hpa on the first hitting host
> pages, is implemented in this patch. Async data path recursively calls
> this new function to construct a multi-segments async copy descriptor
> for ring buffers crossing physical page boundaries.
>
> Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> v2:
> - change commit message and title
> - v1 patch used CPU to copy multi-page buffers; v2 patch split the
> copy into multiple async copy segments whenever possible
>
> v3:
> - added fixline
>
> v4:
> - fix miss translation of the gpa which is the same length with host
> page size
> v5:
> - combine redundant "if" statement in async_mbuf_to_desc()
>
> lib/librte_vhost/vhost.h | 50 +++++++++++++++++++++++++++++++++++
> lib/librte_vhost/virtio_net.c | 39 ++++++++++++++++-----------
> 2 files changed, 74 insertions(+), 15 deletions(-)
Thanks Patrick, it looks better to me now:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Maxime
next prev parent reply other threads:[~2020-07-29 14:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 2:52 [dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path patrick.fu
2020-07-20 16:39 ` Maxime Coquelin
2020-07-21 2:57 ` Fu, Patrick
2020-07-21 8:35 ` Maxime Coquelin
2020-07-21 9:01 ` Fu, Patrick
2020-07-24 13:49 ` [dpdk-dev] [PATCH v2] vhost: fix async copy fail on multi-page buffers patrick.fu
2020-07-27 6:33 ` [dpdk-dev] [PATCH v3] " patrick.fu
2020-07-27 13:14 ` Xia, Chenbo
2020-07-28 3:09 ` Fu, Patrick
2020-07-28 3:28 ` [dpdk-dev] [PATCH v4] " patrick.fu
2020-07-28 13:55 ` Maxime Coquelin
2020-07-29 1:40 ` Fu, Patrick
2020-07-29 2:05 ` Fu, Patrick
2020-07-29 2:04 ` [dpdk-dev] [PATCH v5] " Patrick Fu
2020-07-29 14:24 ` Maxime Coquelin [this message]
2020-07-29 14:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48c6a8e-914f-9bd7-d122-7ef5de315a7a@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=patrick.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).