From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>, <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver
Date: Tue, 28 Mar 2017 17:12:47 +0530 [thread overview]
Message-ID: <a4f2aa11-4c72-e2bb-9b6c-96ba4b3cdf50@nxp.com> (raw)
In-Reply-To: <20170324172227.5bdfac8c@platinum>
Hello Olivier,
On Friday 24 March 2017 09:52 PM, Olivier Matz wrote:
[..]
> I tried to pass the mempool autotest, and it issues a segfault.
> I think the libraries are missing in rte.app.mk, so no handler is
> registered.
I have been trying to simulate the segfault that you are referring to
above. But, I think it should not be the case. If a mempool handler is
not registered (as librte_mempool_ring was not included in
mk/rte.app.mk, so, no "ring_mp_mc"), the caller would get error.
The mempool_autotest is reporting:
--->8--
RTE>>mempool_autotest
cannot allocate mp_nocache mempool
Test Failed
--->8--
>
> Adding the following code in lib/librte_mempool/rte_mempool_ops.c
> fixes the crash.
>
> ops = rte_mempool_get_ops(mp->ops_index);
> + if (ops == NULL || ops->alloc == NULL)
> + return -ENOTSUP;
> return ops->alloc(mp);
Can you tell me for which case did your code reach
rte_mempool_ops_alloc() and segfault?
In my case, librte_mempool_ring and librte_mempool_stack are not added
to mk/rte.app.mk and it is static compilation.
>
> Now that drivers are not linked to the mempool library, it can
> happen that there is no handler. Could you please add this patch in your
> patchset?
Yes, once I can get this issue reproduced. Because I think there is one
more place similar code should go (rte_mempool_ops_getcount).
As per what I can see, this would only happen if rte_mempool_xmem_create
is called and then directly alloc is called. That is not happening for
mempool_autotest.
-
Shreyansh
next prev parent reply other threads:[~2017-03-28 11:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 10:03 Shreyansh Jain
2017-03-20 10:03 ` [dpdk-dev] [PATCH 2/2] drivers/mempool: add ring " Shreyansh Jain
2017-03-20 14:50 ` [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack " Hunt, David
2017-03-21 4:55 ` Shreyansh Jain
2017-03-21 6:02 ` Wiles, Keith
2017-03-21 6:25 ` Shreyansh Jain
2017-03-21 6:28 ` Shreyansh Jain
2017-03-21 14:45 ` Wiles, Keith
2017-03-24 16:22 ` Olivier Matz
2017-03-27 4:54 ` Shreyansh Jain
2017-03-27 7:22 ` Olivier Matz
2017-03-28 11:42 ` Shreyansh Jain [this message]
2017-03-29 8:18 ` Olivier Matz
2017-03-29 12:55 ` Shreyansh Jain
2017-03-30 12:35 ` Olivier Matz
2017-03-31 5:29 ` [dpdk-dev] [PATCH 1/3] mempool: fix segfault for unlinked mempool handler Shreyansh Jain
2017-03-31 5:29 ` [dpdk-dev] [PATCH 2/3] mempool: introduce ring mempool driver Shreyansh Jain
2017-03-31 5:29 ` [dpdk-dev] [PATCH 3/3] mempool: introduce stack " Shreyansh Jain
2017-03-31 5:31 ` [dpdk-dev] [PATCH 1/3] mempool: fix segfault for unlinked mempool handler Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4f2aa11-4c72-e2bb-9b6c-96ba4b3cdf50@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).