From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Lijuan Tu <lijuan.tu@intel.com>,
"Owen Hilyard" <ohilyard@iol.unh.edu>
Subject: RE: [PATCH] devtools: set DTS directory to format check
Date: Thu, 10 Nov 2022 10:53:33 +0000 [thread overview]
Message-ID: <a50d522dc02e4c2d867da876226241c9@pantheon.tech> (raw)
In-Reply-To: <1729999.A0I09U8b9p@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, November 10, 2022 11:26 AM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: dev@dpdk.org; Lijuan Tu <lijuan.tu@intel.com>; Owen Hilyard
> <ohilyard@iol.unh.edu>
> Subject: Re: [PATCH] devtools: set DTS directory to format check
>
> 10/11/2022 10:27, Juraj Linkeš:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > usage() {
> > > - echo "Run formatting and linting programs for DTS. Usage:"
> > > -
> > > + echo 'Usage: $(basename $0) [options] [directory]'
> >
> > Double quotes here, otherwise $0 won't be expanded.
>
> I wonder how I tested it :)
>
> > > +directory=${1:-$(dirname $0)/../dts} cd $directory || exit 1
> >
> > I'd like to include the information of where we're doing the fomatting in
> the console output, e.g.:
> > echo "Formatting in $(pwd):"
> >
> > We're silently chaning the directory, so this would be useful when running
> with no argument and the script doesn't change anything - as a confirmation
> that it ran over the files we wanted to.
>
> Good comment, I'll improve in v2.
One more thing, if we go with changing the Formatting echo, then we should also change the Linting echo. Or we could do it in some other place just once, I'm not sure which is better.
>
> > Other than that,
> > Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > Tested-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
>
> No it does not work, so you should not add your Tested-by.
> And in general, Reviewed-by is enough.
> And really, give your reviewed-by only when it's perfect :)
>
Thanks. It actually does work (by which I mean it does format and lint), but it's not perfect, so I guess Tested-by should be fine, but Reviewed-by isn't? :-)
next prev parent reply other threads:[~2022-11-10 10:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 17:09 Thomas Monjalon
2022-11-09 17:38 ` Owen Hilyard
2022-11-10 9:27 ` Juraj Linkeš
2022-11-10 10:26 ` Thomas Monjalon
2022-11-10 10:53 ` Juraj Linkeš [this message]
2022-11-11 10:06 ` Juraj Linkeš
2022-11-11 10:12 ` Thomas Monjalon
2022-11-23 11:22 ` [PATCH v2] " Thomas Monjalon
2022-11-23 13:41 ` Juraj Linkeš
2022-11-23 15:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a50d522dc02e4c2d867da876226241c9@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=dev@dpdk.org \
--cc=lijuan.tu@intel.com \
--cc=ohilyard@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).