From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: dev@dpdk.org, david.marchand@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: switch to pci_alloc_irq_vectors()
Date: Thu, 20 Apr 2017 12:59:57 +0100 [thread overview]
Message-ID: <a590a8dd-994c-ee21-3a2b-03f379bbcc7e@intel.com> (raw)
In-Reply-To: <20170420090140.30566-1-nicolas.dichtel@6wind.com>
On 4/20/2017 10:01 AM, Nicolas Dichtel wrote:
> pci_enable_msix() will be removed in kernel 4.12. The new API is available
> since linux 4.8, thus let's use it.
>
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aff171641d18
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=4244de1c64de
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Reviewed-by: David Marchand <david.marchand@6wind.com>
<...>
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0)
> +#define HAVE_PCI_ENABLE_MSIX
> +#endif
Would you mind moving this check to the end of the file, to preserve
version check in increasing order (although I aware some doesn't fit this)?
When above done:
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2017-04-20 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 14:56 [dpdk-dev] [PATCH] " Nicolas Dichtel
2017-04-19 18:33 ` Ferruh Yigit
2017-04-20 9:01 ` [dpdk-dev] [PATCH v2] " Nicolas Dichtel
2017-04-20 11:59 ` Ferruh Yigit [this message]
2017-04-20 13:07 ` Nicolas Dichtel
2017-04-20 13:11 ` [dpdk-dev] [PATCH v3] " Nicolas Dichtel
2017-04-20 13:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a590a8dd-994c-ee21-3a2b-03f379bbcc7e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).