From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>
Cc: dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
xiao.w.wang@intel.com, Rami Rosen <roszenrami@gmail.com>,
Wang Haiyue <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA
Date: Fri, 28 Sep 2018 10:31:34 +0200 [thread overview]
Message-ID: <a69fcc6b-ae4f-b0c7-33ea-ecbf3daa2fac@redhat.com> (raw)
In-Reply-To: <20180928151733.GA44818@intel.com>
On 09/28/2018 05:17 PM, Ye Xiaolong wrote:
> On 09/28, Maxime Coquelin wrote:
>>
>>
>> On 09/28/2018 04:33 PM, Ye Xiaolong wrote:
>>> On 09/28, Maxime Coquelin wrote:
>>>>> + ret = rte_eal_init(argc, argv);
>>>>> + if (ret < 0)
>>>>> + rte_exit(EXIT_FAILURE, "eal init failed\n");
>>>>> + argc -= ret;
>>>>> + argv += ret;
>>>>> +
>>>>> + data_init();
>>>>
>>>> You need to check return from data_init().
>>>> If this is fine for you, I can change to below code when applying:
>>>>
>>>> ret = data_init();
>>>> if (ret < 0)
>>>> rte_exit(EXIT_FAILURE, "data init failed\n");
>>>>
>>>>
>>>
>>> I'm fine with this change.
>>
>> Or even better, get rid of data_init and
>> call rte_vdpa_get_device_num(); in main directly.
>
> Sounds better, as we've removed unnecessary static variable initialization in
> data_init, it does nothing but call rte_vdpa_get_device_num, we can remove this
> wrap. Would you do this change when applying or you perfer I send a new
> revision?
Please send a new revision, and in the commit message,
fix first letter of my family name with an upper case,
and move my R-b below your sign-off.
Thanks!
Maxime
> Thanks,
> Xiaolong
>
>
>>
>>> Thanks,
>>> Xiaolong
>>>
next prev parent reply other threads:[~2018-09-28 8:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 22:28 [dpdk-dev] [PATCH v3 0/2] introduce vdpa sample Xiaolong Ye
2018-09-20 22:28 ` [dpdk-dev] [PATCH v3 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-20 22:28 ` [dpdk-dev] [PATCH v3 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-21 5:07 ` Wang, Xiao W
2018-09-22 11:04 ` Ye Xiaolong
2018-09-24 8:42 ` [dpdk-dev] [PATCH v4 0/2] introduce vdpa sample Xiaolong Ye
2018-09-24 8:42 ` [dpdk-dev] [PATCH v4 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-24 8:42 ` [dpdk-dev] [PATCH v4 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-24 4:12 ` Wang, Xiao W
2018-09-24 21:30 ` Ye Xiaolong
2018-09-25 12:07 ` [dpdk-dev] [PATCH v5 0/2] introduce vdpa sample Xiaolong Ye
2018-09-25 12:07 ` [dpdk-dev] [PATCH v5 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-25 12:07 ` [dpdk-dev] [PATCH v5 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-25 8:32 ` Wang, Xiao W
2018-09-26 9:06 ` [dpdk-dev] [PATCH v6 0/2] introduce vdpa sample Xiaolong Ye
2018-09-26 3:15 ` Wang, Xiao W
2018-09-26 9:06 ` [dpdk-dev] [PATCH v6 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-26 9:06 ` [dpdk-dev] [PATCH v6 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-27 16:37 ` Maxime Coquelin
2018-09-28 7:32 ` Ye Xiaolong
2018-09-28 11:23 ` [dpdk-dev] [PATCH v7 0/2] introduce vdpa sample Xiaolong Ye
2018-09-28 11:23 ` [dpdk-dev] [PATCH v7 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-09-28 11:23 ` [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-09-28 7:31 ` Maxime Coquelin
2018-09-28 14:33 ` Ye Xiaolong
2018-09-28 7:49 ` Maxime Coquelin
2018-09-28 15:17 ` Ye Xiaolong
2018-09-28 8:31 ` Maxime Coquelin [this message]
2018-09-28 17:37 ` Ye Xiaolong
2018-09-28 21:47 ` [dpdk-dev] [PATCH v8 0/2] introduce vdpa sample Xiaolong Ye
2018-09-28 21:47 ` [dpdk-dev] [PATCH v8 1/2] vhost: introduce API to get vDPA device number Xiaolong Ye
2018-10-02 13:19 ` Ferruh Yigit
2018-10-03 5:53 ` Ye Xiaolong
2018-09-28 21:47 ` [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample for vDPA Xiaolong Ye
2018-10-02 14:03 ` Ferruh Yigit
2018-10-03 6:04 ` Ye Xiaolong
2018-10-03 7:48 ` Ferruh Yigit
2019-01-17 14:37 ` Shahaf Shuler
2019-01-17 15:13 ` Ye Xiaolong
2019-01-17 15:17 ` Shahaf Shuler
2018-10-02 12:51 ` [dpdk-dev] [PATCH v8 0/2] introduce vdpa sample Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a69fcc6b-ae4f-b0c7-33ea-ecbf3daa2fac@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=roszenrami@gmail.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).