From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Sunil Kumar Kori <sunil.kori@nxp.com>, dev@dpdk.org
Cc: hemant.agrawal@nxp.com
Subject: Re: [dpdk-dev] [PATCH 2/2] net/dpaa2: Changes to support ethdev offload APIs
Date: Tue, 10 Apr 2018 17:47:54 +0100 [thread overview]
Message-ID: <a6d987a3-c06d-e91f-acf6-fe82356a7ffc@intel.com> (raw)
In-Reply-To: <20180409131952.20948-2-sunil.kori@nxp.com>
On 4/9/2018 2:19 PM, Sunil Kumar Kori wrote:
> Signed-off-by: Sunil Kumar Kori <sunil.kori@nxp.com>
> ---
> drivers/net/dpaa2/dpaa2_ethdev.c | 63 +++++++++++++++++++++++++++++++++-------
> drivers/net/dpaa2/dpaa2_rxtx.c | 32 +++++++-------------
I see more old API related usage after this patch, can you please check if they
should be updated:
drivers/net/dpaa2/dpaa2_rxtx.c
560: if (dev->data->dev_conf.rxmode.hw_vlan_strip)
drivers/net/dpaa2/dpaa2_ethdev.c
106: if (dev->data->dev_conf.rxmode.hw_vlan_filter)
117: if (dev->data->dev_conf.rxmode.hw_vlan_extend)
993: dev->data->dev_conf.rxmode.jumbo_frame = 1;
995: dev->data->dev_conf.rxmode.jumbo_frame = 0;
<...>
> + dev_info->default_rxconf.rx_drop_en = true;
This change is not related to the offload API I believe, if this is required
what do you think to split into another patch?
<...>
next prev parent reply other threads:[~2018-04-10 16:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:26 [dpdk-dev] [PATCH 0/2] Support for new Ethdev " Sunil Kumar Kori
2018-04-09 10:26 ` [dpdk-dev] [PATCH 1/2] net/dpaa: Changes to support ethdev " Sunil Kumar Kori
2018-04-09 13:19 ` Sunil Kumar Kori
2018-04-09 13:19 ` [dpdk-dev] [PATCH 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-10 16:47 ` Ferruh Yigit [this message]
2018-04-10 16:40 ` [dpdk-dev] [PATCH 1/2] net/dpaa: " Ferruh Yigit
2018-04-09 10:26 ` [dpdk-dev] [PATCH 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-11 11:05 ` [dpdk-dev] [PATCH v2 0/2] Support for new Ethdev " Sunil Kumar Kori
2018-04-11 11:05 ` [dpdk-dev] [PATCH v2 1/2] net/dpaa: Changes to support ethdev " Sunil Kumar Kori
2018-04-11 11:05 ` [dpdk-dev] [PATCH v2 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-12 18:17 ` [dpdk-dev] [PATCH v2 0/2] Support for new Ethdev " Ferruh Yigit
2018-04-24 15:06 ` [dpdk-dev] [PATCH v3 1/2] net/dpaa: fix the ethdev offload checks Hemant Agrawal
2018-04-24 15:06 ` [dpdk-dev] [PATCH v3 2/2] net/dpaa2: " Hemant Agrawal
2018-04-24 16:43 ` [dpdk-dev] [PATCH v3 1/2] net/dpaa: " Ferruh Yigit
2018-04-24 17:23 ` Hemant Agrawal
2018-04-24 17:16 ` [dpdk-dev] [PATCH v4 " Hemant Agrawal
2018-04-24 17:16 ` [dpdk-dev] [PATCH v4 2/2] net/dpaa2: " Hemant Agrawal
2018-04-24 18:04 ` [dpdk-dev] [PATCH v4 1/2] net/dpaa: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d987a3-c06d-e91f-acf6-fe82356a7ffc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sunil.kori@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).