From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix counters
Date: Wed, 23 Dec 2020 08:03:27 +0000 [thread overview]
Message-ID: <a6e4894727e1461fbc16edef42f85530@intel.com> (raw)
In-Reply-To: <20201117085639.40307-1-iryzhov@nfware.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Igor Ryzhov
> Sent: Tuesday, November 17, 2020 4:57 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix counters
>
> When low and high registers are read separately, this opens the door to a race
> condition:
> - low register is read
> - NIC updates the registers
> - high register is read
>
> Because of this, we may end up with an incorrect counter value.
> Let's read the registers in one shot, as it is done in Linux kernel since the
> introduction of the i40e driver.
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Cc: stable@dpdk.org
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2020-12-23 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 8:56 [dpdk-stable] " Igor Ryzhov
2020-11-19 18:27 ` Igor Ryzhov
2020-11-24 3:34 ` Guo, Jia
2020-11-24 8:24 ` Thomas Monjalon
2020-11-24 9:42 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2020-11-24 10:07 ` Igor Ryzhov
2020-12-23 8:03 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6e4894727e1461fbc16edef42f85530@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).