From: "Hunt, David" <david.hunt@intel.com>
To: Tadhg Kearney <tadhg.kearney@intel.com>, <dev@dpdk.org>
Cc: <anatoly.burakov@intel.com>, <reshma.pattan@intel.com>
Subject: Re: [PATCH v7 0/3] add uncore api to be called through l3fwd-power
Date: Thu, 29 Sep 2022 14:27:33 +0100 [thread overview]
Message-ID: <a6f3ee7c-b054-e641-f0ff-7f0c0209714e@intel.com> (raw)
In-Reply-To: <20220928133018.1583280-1-tadhg.kearney@intel.com>
Hi Tadhg,
On 28/09/2022 14:30, Tadhg Kearney wrote:
> This is targeting 22.11 and aims to add an API to DPDK power library to allow
> uncore frequency adjustment. This will be called through the l3fwd-power app
> and gives the ability to set the minimum and maximum uncore frequency to both min,
> max or specific frequency index.
>
> Signed-off-by: tadhgkearney <tadhg.kearney@intel.com>
> Reviewed-by: David Hunt <david.hunt@intel.com>
> ---
>
> v2:
> Fix compilation warnings and errors.
> v3:
> Remove addition of x86 global macros.
> Add 2 new API's for getting package and die numbers from system.
> Address comments from mailing list.
> Improve efficiency of code and code quality.
> v4:
> Fix compilation warnings and errors.
> v5:
> Improve error message for uncore access not working.
> v6:
> Fix uncore exit being called if uncore option not selected.
> v7:
> Address ml comments.
>
>
> Tadhg Kearney (3):
> power: add uncore frequency control API to the power library
> l3fwd-power: add option to call uncore API
> test/power: add unit tests for uncore API
>
> app/test/meson.build | 2 +
> app/test/test_power_uncore.c | 301 ++++++++++++
> doc/guides/prog_guide/power_man.rst | 38 ++
> doc/guides/rel_notes/release_22_11.rst | 5 +
> .../sample_app_ug/l3_forward_power_man.rst | 29 ++
> examples/l3fwd-power/main.c | 126 ++++-
> lib/power/meson.build | 2 +
> lib/power/rte_power_uncore.c | 451 ++++++++++++++++++
> lib/power/rte_power_uncore.h | 194 ++++++++
> lib/power/version.map | 11 +
> 10 files changed, 1157 insertions(+), 2 deletions(-)
> create mode 100644 app/test/test_power_uncore.c
> create mode 100644 lib/power/rte_power_uncore.c
> create mode 100644 lib/power/rte_power_uncore.h
Latest revision looks good to me. Consider the series:
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2022-09-29 13:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 9:48 [PATCH v4 " Tadhg Kearney
2022-09-20 9:48 ` [PATCH v4 1/3] power: add uncore frequency control API to the power library Tadhg Kearney
2022-09-23 13:15 ` Hunt, David
2022-09-20 9:48 ` [PATCH v4 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-09-23 13:13 ` Hunt, David
2022-09-20 9:48 ` [PATCH v4 3/3] test/power: add unit tests for " Tadhg Kearney
2022-09-23 13:15 ` Hunt, David
2022-09-27 10:09 ` [PATCH v5 0/3] add uncore api to be called through l3fwd-power Tadhg Kearney
2022-09-27 10:09 ` [PATCH v5 1/3] power: add uncore frequency control API to the power library Tadhg Kearney
2022-09-27 10:09 ` [PATCH v5 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-09-27 10:09 ` [PATCH v5 3/3] test/power: add unit tests for " Tadhg Kearney
2022-09-28 9:06 ` [PATCH v6 0/3] add uncore api to be called through l3fwd-power Tadhg Kearney
2022-09-28 9:06 ` [PATCH v6 1/3] power: add uncore frequency control API to the power library Tadhg Kearney
2022-09-28 9:06 ` [PATCH v6 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-09-28 12:18 ` Hunt, David
2022-09-28 9:06 ` [PATCH v6 3/3] test/power: add unit tests for " Tadhg Kearney
2022-09-28 13:30 ` [PATCH v7 0/3] add uncore api to be called through l3fwd-power Tadhg Kearney
2022-09-28 13:30 ` [PATCH v7 1/3] power: add uncore frequency control API to the power library Tadhg Kearney
2022-10-04 17:09 ` Thomas Monjalon
2022-10-05 10:50 ` Kearney, Tadhg
2022-10-05 12:11 ` Thomas Monjalon
2022-09-28 13:30 ` [PATCH v7 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-09-28 13:30 ` [PATCH v7 3/3] test/power: add unit tests for " Tadhg Kearney
2022-09-29 13:27 ` Hunt, David [this message]
2022-10-05 16:20 ` [PATCH v8 0/3] add Intel uncore api to be called through l3fwd-power Tadhg Kearney
2022-10-05 16:20 ` [PATCH v8 1/3] power: add Intel uncore frequency control API to power library Tadhg Kearney
2022-10-05 16:20 ` [PATCH v8 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-10-05 16:20 ` [PATCH v8 3/3] test/power: add unit tests for " Tadhg Kearney
2022-10-06 9:38 ` [PATCH v9 0/3] add Intel uncore api to be called through l3fwd-power Tadhg Kearney
2022-10-06 9:38 ` [PATCH v9 1/3] power: add Intel uncore frequency control API to power library Tadhg Kearney
2022-10-06 17:32 ` Stephen Hemminger
2022-10-07 10:30 ` Hunt, David
2022-10-10 12:46 ` Thomas Monjalon
2022-10-06 9:38 ` [PATCH v9 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-10-06 9:38 ` [PATCH v9 3/3] test/power: add unit tests for " Tadhg Kearney
2022-10-10 12:52 ` [PATCH v9 0/3] add Intel uncore api to be called through l3fwd-power Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f3ee7c-b054-e641-f0ff-7f0c0209714e@intel.com \
--to=david.hunt@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=tadhg.kearney@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).