From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v2 10/16] test/bbdev: adjustment for soft output
Date: Wed, 22 Feb 2023 11:50:50 +0100 [thread overview]
Message-ID: <a75038ab-6ce3-797f-87df-01b08cffa1c8@redhat.com> (raw)
In-Reply-To: <20230215170949.60569-11-hernan.vargas@intel.com>
On 2/15/23 18:09, Hernan Vargas wrote:
> Extend test-bbdev for soft output check, notably due to the logic in
> test-bbdev to enable termination changing.
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> app/test-bbdev/test_bbdev_perf.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index bdddf4f8b2..00090f863f 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -1349,6 +1349,7 @@ fill_queue_buffers(struct test_op_params *op_params,
> RTE_BBDEV_LDPC_LLR_COMPRESSION;
> bool harq_comp = op_params->ref_dec_op->ldpc_dec.op_flags &
> RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION;
> +
> ldpc_llr_decimals = capabilities->cap.ldpc_dec.llr_decimals;
> ldpc_llr_size = capabilities->cap.ldpc_dec.llr_size;
> ldpc_cap_flags = capabilities->cap.ldpc_dec.capability_flags;
> @@ -2424,7 +2425,7 @@ validate_ldpc_dec_op(struct rte_bbdev_dec_op **ops, const uint16_t n,
> i);
>
> if (ref_op->ldpc_dec.op_flags & RTE_BBDEV_LDPC_SOFT_OUT_ENABLE)
> - TEST_ASSERT_SUCCESS(validate_op_chain(soft_output,
> + TEST_ASSERT_SUCCESS(validate_op_so_chain(soft_output,
> soft_data_orig),
> "Soft output buffers (CB=%u) are not equal",
> i);
> @@ -2494,7 +2495,6 @@ validate_ldpc_enc_op(struct rte_bbdev_enc_op **ops, const uint16_t n,
> return TEST_SUCCESS;
> }
>
> -
> static inline int
> validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op)
> {
> @@ -3181,11 +3181,11 @@ throughput_intr_lcore_ldpc_dec(void *arg)
> for (j = 0; j < TEST_REPETITIONS; ++j) {
> for (i = 0; i < num_to_process; ++i) {
> if (!loopback)
> - rte_pktmbuf_reset(
> - ops[i]->ldpc_dec.hard_output.data);
> + rte_pktmbuf_reset(ops[i]->ldpc_dec.hard_output.data);
> if (hc_out || loopback)
> - mbuf_reset(
> - ops[i]->ldpc_dec.harq_combined_output.data);
> + mbuf_reset(ops[i]->ldpc_dec.harq_combined_output.data);
> + if (ops[i]->ldpc_dec.soft_output.data != NULL)
> + rte_pktmbuf_reset(ops[i]->ldpc_dec.soft_output.data);
> }
>
> tp->start_time = rte_rdtsc_precise();
> @@ -3280,7 +3280,6 @@ throughput_intr_lcore_dec(void *arg)
> rte_pktmbuf_reset(ops[i]->turbo_dec.soft_output.data);
> }
>
> -
> tp->start_time = rte_rdtsc_precise();
> for (enqueued = 0; enqueued < num_to_process;) {
> num_to_enq = burst_sz;
> @@ -3742,10 +3741,11 @@ bler_pmd_lcore_ldpc_dec(void *arg)
> for (i = 0; i < 1; ++i) { /* Could add more iterations */
> for (j = 0; j < num_ops; ++j) {
> if (!loopback)
> - mbuf_reset(
> - ops_enq[j]->ldpc_dec.hard_output.data);
> + mbuf_reset(ops_enq[j]->ldpc_dec.hard_output.data);
> if (hc_out || loopback)
> mbuf_reset(ops_enq[j]->ldpc_dec.harq_combined_output.data);
> + if (ops_enq[j]->ldpc_dec.soft_output.data != NULL)
> + mbuf_reset(ops_enq[j]->ldpc_dec.soft_output.data);
> }
> if (extDdr)
> preload_harq_ddr(tp->dev_id, queue_id, ops_enq,
> @@ -3977,11 +3977,11 @@ throughput_pmd_lcore_ldpc_dec(void *arg)
> for (i = 0; i < TEST_REPETITIONS; ++i) {
> for (j = 0; j < num_ops; ++j) {
> if (!loopback)
> - mbuf_reset(
> - ops_enq[j]->ldpc_dec.hard_output.data);
> + mbuf_reset(ops_enq[j]->ldpc_dec.hard_output.data);
> if (hc_out || loopback)
> - mbuf_reset(
> - ops_enq[j]->ldpc_dec.harq_combined_output.data);
> + mbuf_reset(ops_enq[j]->ldpc_dec.harq_combined_output.data);
> + if (ops_enq[j]->ldpc_dec.soft_output.data != NULL)
> + mbuf_reset(ops_enq[j]->ldpc_dec.soft_output.data);
> }
> if (extDdr)
> preload_harq_ddr(tp->dev_id, queue_id, ops_enq,
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-02-22 10:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 17:09 [PATCH v2 00/16] test/bbdev: changes for 23.03 Hernan Vargas
2023-02-15 17:09 ` [PATCH v2 01/16] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas
2023-02-20 16:08 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 02/16] test/bbdev: extend HARQ tolerance Hernan Vargas
2023-02-20 16:09 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 03/16] test/bbdev: refactor TB throughput report Hernan Vargas
2023-02-20 16:10 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 04/16] test/bbdev: add timeout for latency tests Hernan Vargas
2023-02-20 16:32 ` Maxime Coquelin
2023-02-22 21:13 ` Vargas, Hernan
2023-02-23 8:31 ` Maxime Coquelin
2023-02-24 16:59 ` Vargas, Hernan
2023-02-27 9:44 ` Maxime Coquelin
2023-02-28 22:37 ` Chautru, Nicolas
2023-03-02 10:12 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 05/16] test/bbdev: enable early termination for validation Hernan Vargas
2023-02-20 20:12 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 06/16] test/bbdev: report device status in test-bbdev Hernan Vargas
2023-02-20 20:17 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 07/16] test/bbdev: test start/stop bbdev API Hernan Vargas
2023-02-20 20:21 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 08/16] test/bbdev: add support for BLER for 4G Hernan Vargas
2023-02-22 10:48 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 09/16] test/bbdev: extend support for large TB Hernan Vargas
2023-02-22 10:49 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 10/16] test/bbdev: adjustment for soft output Hernan Vargas
2023-02-22 10:50 ` Maxime Coquelin [this message]
2023-02-15 17:09 ` [PATCH v2 11/16] test/bbdev: expose warning counters Hernan Vargas
2023-02-22 10:52 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 12/16] test/bbdev: remove check for invalid opaque data Hernan Vargas
2023-02-22 10:53 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 13/16] test/bbdev: remove iteration count check Hernan Vargas
2023-02-22 10:55 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 14/16] test/bbdev: use mbuf reset function Hernan Vargas
2023-02-22 10:56 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 15/16] test/bbdev: remove max iteration from vectors Hernan Vargas
2023-02-22 10:58 ` Maxime Coquelin
2023-02-15 17:09 ` [PATCH v2 16/16] test/bbdev: remove iter count from bler test Hernan Vargas
2023-02-22 11:01 ` Maxime Coquelin
2023-02-20 15:31 ` [PATCH v2 00/16] test/bbdev: changes for 23.03 Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a75038ab-6ce3-797f-87df-01b08cffa1c8@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).