From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nic Chautru <nicolas.chautru@intel.com>,
dev@dpdk.org, thomas@monjalon.net
Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com,
hemant.agrawal@nxp.com, david.marchand@redhat.com,
stephen@networkplumber.org, hernan.vargas@intel.com
Subject: Re: From: Nic Chautru <nicolas.chautru@intel.com>
Date: Fri, 23 Sep 2022 13:41:50 +0200 [thread overview]
Message-ID: <a7abde49-9f72-823c-3c77-839cc8e0bcc7@redhat.com> (raw)
In-Reply-To: <1663806460-45162-1-git-send-email-nicolas.chautru@intel.com>
Hi Nicolas,
I'm done with v4 review.
Please post a v6, I don't plan to review v5 that was posted while I was
in the middle of my review.
Thanks,
Maxime
On 9/22/22 02:27, Nic Chautru wrote:
> v4: Rebase to split the first commit and change the order within
> the series based on Maxime's feedback. No functional change.
> v3: Merge ACC100 and ACC200 PMDs in the same directory
> v2: Includes now code refactory to have common structures and code reused with the
> parallel ACC1XX serie PMD which can be shared moving forward.
> v1: This is targeting 22.11 and includes the PMD for the
> new integrated accelerator on Intel Xeon SPR-EEC.
> There is a dependency on that parallel patch serie still in-flight
> which extends the bbdev api https://patches.dpdk.org/project/dpdk/list/?series=23894
> and is required to apply that patch.
>
>
> Nic Chautru (14):
> baseband/acc100: remove unused registers
> baseband/acc100: refactor to segregate common code
> baseband/acc: rename directory from acc100 to acc
> baseband/acc: introduce PMD for ACC200
> baseband/acc: add HW register definitions for ACC200
> baseband/acc: add info get function for ACC200
> baseband/acc: add queue configuration for ACC200
> baseband/acc: add LDPC processing functions
> baseband/acc: add LTE processing functions
> baseband/acc: add support for FFT operations
> baseband/acc: support interrupt
> baseband/acc: add device status and vf2pf comms
> baseband/acc: add PF configure companion function
> baseband/acc: simplify meson dependency
>
> MAINTAINERS | 5 +-
> app/test-bbdev/meson.build | 4 +-
> app/test-bbdev/test_bbdev_perf.c | 81 +-
> doc/guides/bbdevs/acc200.rst | 244 ++
> doc/guides/bbdevs/index.rst | 1 +
> drivers/baseband/acc/acc100_pf_enum.h | 147 +
> drivers/baseband/acc/acc100_pmd.h | 177 +
> drivers/baseband/acc/acc100_vf_enum.h | 73 +
> drivers/baseband/acc/acc101_pmd.h | 40 +
> drivers/baseband/acc/acc200_pf_enum.h | 108 +
> drivers/baseband/acc/acc200_pmd.h | 196 ++
> drivers/baseband/acc/acc200_vf_enum.h | 83 +
> drivers/baseband/acc/acc_common.h | 1387 ++++++++
> drivers/baseband/acc/meson.build | 8 +
> drivers/baseband/acc/rte_acc100_cfg.h | 49 +
> drivers/baseband/acc/rte_acc100_pmd.c | 4655 +++++++++++++++++++++++++
> drivers/baseband/acc/rte_acc200_cfg.h | 48 +
> drivers/baseband/acc/rte_acc200_pmd.c | 4195 +++++++++++++++++++++++
> drivers/baseband/acc/rte_acc_common_cfg.h | 101 +
> drivers/baseband/acc/version.map | 10 +
> drivers/baseband/acc100/acc100_pf_enum.h | 1086 ------
> drivers/baseband/acc100/acc100_pmd.h | 624 ----
> drivers/baseband/acc100/acc100_vf_enum.h | 73 -
> drivers/baseband/acc100/acc101_pmd.h | 50 -
> drivers/baseband/acc100/meson.build | 8 -
> drivers/baseband/acc100/rte_acc100_cfg.h | 113 -
> drivers/baseband/acc100/rte_acc100_pmd.c | 5288 -----------------------------
> drivers/baseband/acc100/version.map | 9 -
> drivers/baseband/meson.build | 2 +-
> 29 files changed, 11605 insertions(+), 7260 deletions(-)
> create mode 100644 doc/guides/bbdevs/acc200.rst
> create mode 100644 drivers/baseband/acc/acc100_pf_enum.h
> create mode 100644 drivers/baseband/acc/acc100_pmd.h
> create mode 100644 drivers/baseband/acc/acc100_vf_enum.h
> create mode 100644 drivers/baseband/acc/acc101_pmd.h
> create mode 100644 drivers/baseband/acc/acc200_pf_enum.h
> create mode 100644 drivers/baseband/acc/acc200_pmd.h
> create mode 100644 drivers/baseband/acc/acc200_vf_enum.h
> create mode 100644 drivers/baseband/acc/acc_common.h
> create mode 100644 drivers/baseband/acc/meson.build
> create mode 100644 drivers/baseband/acc/rte_acc100_cfg.h
> create mode 100644 drivers/baseband/acc/rte_acc100_pmd.c
> create mode 100644 drivers/baseband/acc/rte_acc200_cfg.h
> create mode 100644 drivers/baseband/acc/rte_acc200_pmd.c
> create mode 100644 drivers/baseband/acc/rte_acc_common_cfg.h
> create mode 100644 drivers/baseband/acc/version.map
> delete mode 100644 drivers/baseband/acc100/acc100_pf_enum.h
> delete mode 100644 drivers/baseband/acc100/acc100_pmd.h
> delete mode 100644 drivers/baseband/acc100/acc100_vf_enum.h
> delete mode 100644 drivers/baseband/acc100/acc101_pmd.h
> delete mode 100644 drivers/baseband/acc100/meson.build
> delete mode 100644 drivers/baseband/acc100/rte_acc100_cfg.h
> delete mode 100644 drivers/baseband/acc100/rte_acc100_pmd.c
> delete mode 100644 drivers/baseband/acc100/version.map
>
next prev parent reply other threads:[~2022-09-23 11:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 0:27 Nic Chautru
2022-09-22 0:27 ` [PATCH v4 01/14] baseband/acc100: remove unused registers Nic Chautru
2022-09-22 0:37 ` Chautru, Nicolas
2022-09-22 13:08 ` Maxime Coquelin
2022-09-22 13:09 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 02/14] baseband/acc100: refactor to segregate common code Nic Chautru
2022-09-22 13:15 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 03/14] baseband/acc: rename directory from acc100 to acc Nic Chautru
2022-09-22 13:17 ` Maxime Coquelin
2022-09-22 18:06 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 04/14] baseband/acc: introduce PMD for ACC200 Nic Chautru
2022-09-22 14:01 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 05/14] baseband/acc: add HW register definitions " Nic Chautru
2022-09-22 14:04 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 06/14] baseband/acc: add info get function " Nic Chautru
2022-09-22 14:11 ` Maxime Coquelin
2022-09-22 18:20 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 07/14] baseband/acc: add queue configuration " Nic Chautru
2022-09-22 14:30 ` Maxime Coquelin
2022-09-22 18:51 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 08/14] baseband/acc: add LDPC processing functions Nic Chautru
2022-09-23 8:29 ` Maxime Coquelin
2022-09-23 21:55 ` Chautru, Nicolas
2022-09-27 13:12 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 09/14] baseband/acc: add LTE " Nic Chautru
2022-09-23 8:59 ` Maxime Coquelin
2022-09-23 22:21 ` Chautru, Nicolas
2022-09-27 13:33 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 10/14] baseband/acc: add support for FFT operations Nic Chautru
2022-09-23 9:05 ` Maxime Coquelin
2022-09-23 22:31 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 11/14] baseband/acc: support interrupt Nic Chautru
2022-09-23 9:17 ` Maxime Coquelin
2022-09-23 22:58 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 12/14] baseband/acc: add device status and vf2pf comms Nic Chautru
2022-09-23 9:23 ` Maxime Coquelin
2022-09-24 0:04 ` Chautru, Nicolas
2022-09-22 0:27 ` [PATCH v4 13/14] baseband/acc: add PF configure companion function Nic Chautru
2022-09-23 9:26 ` Maxime Coquelin
2022-09-24 0:20 ` Chautru, Nicolas
2022-09-27 13:56 ` Maxime Coquelin
2022-09-22 0:27 ` [PATCH v4 14/14] baseband/acc: simplify meson dependency Nic Chautru
2022-09-23 11:41 ` Maxime Coquelin [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-22 20:34 From: Nic Chautru <nicolas.chautru@intel.com> Nic Chautru
2022-09-16 1:34 Nic Chautru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7abde49-9f72-823c-3c77-839cc8e0bcc7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=hernan.vargas@intel.com \
--cc=mdr@ashroe.eu \
--cc=nicolas.chautru@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).