From: Remy Horton <remy.horton@intel.com>
To: dev@dpdk.org
Cc: Zijie Pan <zijie.pan@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 2/5] examples/ethtool: add a new command module-eeprom
Date: Tue, 13 Mar 2018 14:46:34 +0000 [thread overview]
Message-ID: <a86b55f0-3287-0b5f-0adc-6cfc278c3c49@intel.com> (raw)
In-Reply-To: <1520828243-25191-3-git-send-email-zijie.pan@6wind.com>
Comments inline. On the whole looks good to me.
On 12/03/2018 04:17, Zijie Pan wrote:
[..]
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> ---
> doc/guides/sample_app_ug/ethtool.rst | 2 ++
> examples/ethtool/ethtool-app/ethapp.c | 61 +++++++++++++++++++++++++++++++++
> examples/ethtool/lib/rte_ethtool.c | 30 ++++++++++++++++
> examples/ethtool/lib/rte_ethtool.h | 34 ++++++++++++++++++
> 4 files changed, 127 insertions(+)
Reviewed-by: Remy Horton <remy.horton@intel.com>
> cmdline_parse_token_string_t pcmd_eeprom_token_cmd =
> TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "eeprom");
> +cmdline_parse_token_string_t pcmd_module_eeprom_token_cmd =
> + TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "module-eeprom");
Checkpatch: 80 character limit.
> + info_eeprom.len = module_info[1];
> + info_eeprom.offset = 0;
> + stat = rte_ethtool_get_module_eeprom(params->port,
> + &info_eeprom, bytes_eeprom);
> + if (stat != 0 || module_info[1] <= 0) {
This supposed to be module_info[1] rather than info_eeprom.len ?
next prev parent reply other threads:[~2018-03-13 14:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 4:17 [dpdk-dev] [PATCH 0/5] Patches to get the information and data of EEPROM Zijie Pan
2018-03-12 4:17 ` [dpdk-dev] [PATCH 1/5] ethdev: add access to eeprom Zijie Pan
2018-03-13 14:51 ` Remy Horton
2018-03-16 9:38 ` [dpdk-dev] [PATCH v2 " Zijie Pan
2018-03-16 9:59 ` Remy Horton
2018-03-12 4:17 ` [dpdk-dev] [PATCH 2/5] examples/ethtool: add a new command module-eeprom Zijie Pan
2018-03-13 14:46 ` Remy Horton [this message]
2018-03-16 9:41 ` [dpdk-dev] [PATCH v2 " Zijie Pan
2018-03-16 9:59 ` Remy Horton
2018-03-12 4:17 ` [dpdk-dev] [PATCH 3/5] net/ixgbe: add module EEPROM callbacks for ixgbe Zijie Pan
2018-03-13 14:46 ` Remy Horton
2018-03-16 9:42 ` [dpdk-dev] [PATCH v2 " Zijie Pan
2018-03-16 10:08 ` Remy Horton
2018-03-12 4:17 ` [dpdk-dev] [PATCH 4/5] net/e1000: add module EEPROM callbacks for e1000 Zijie Pan
2018-03-16 9:42 ` [dpdk-dev] [PATCH v2 " Zijie Pan
2018-03-12 4:17 ` [dpdk-dev] [PATCH 5/5] net/i40e: add module EEPROM callbacks for i40e Zijie Pan
2018-03-16 9:42 ` [dpdk-dev] [PATCH v2 " Zijie Pan
2018-03-13 15:19 ` [dpdk-dev] [PATCH 0/5] Patches to get the information and data of EEPROM Remy Horton
2018-03-16 9:36 ` [dpdk-dev] [PATCH v2 0/5] " Zijie Pan
2018-03-21 11:06 ` [dpdk-dev] [PATCH v3 " Zijie Pan
2018-03-21 11:06 ` [dpdk-dev] [PATCH v3 1/5] ethdev: add access to eeprom Zijie Pan
2018-04-19 13:34 ` Ferruh Yigit
2018-04-22 21:13 ` Thomas Monjalon
2018-03-21 11:06 ` [dpdk-dev] [PATCH v3 2/5] examples/ethtool: add a new command module-eeprom Zijie Pan
2018-03-21 11:06 ` [dpdk-dev] [PATCH v3 3/5] net/ixgbe: add module EEPROM callbacks for ixgbe Zijie Pan
2018-03-21 11:06 ` [dpdk-dev] [PATCH v3 4/5] net/e1000: add module EEPROM callbacks for e1000 Zijie Pan
2018-03-21 11:06 ` [dpdk-dev] [PATCH v3 5/5] net/i40e: add module EEPROM callbacks for i40e Zijie Pan
2018-04-19 13:36 ` [dpdk-dev] [PATCH v3 0/5] get the information and data of EEPROM Ferruh Yigit
2018-04-19 14:17 ` Remy Horton
2018-04-24 10:17 ` [dpdk-dev] [PATCH v4 " Zijie Pan
2018-04-24 10:17 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add access to eeprom Zijie Pan
2018-04-24 10:25 ` Thomas Monjalon
2018-04-25 8:21 ` Zijie Pan
2018-04-25 8:31 ` Thomas Monjalon
2018-04-24 10:17 ` [dpdk-dev] [PATCH v4 2/5] examples/ethtool: add a new command module-eeprom Zijie Pan
2018-04-24 10:17 ` [dpdk-dev] [PATCH v4 3/5] net/ixgbe: add module EEPROM callbacks for ixgbe Zijie Pan
2018-04-24 10:17 ` [dpdk-dev] [PATCH v4 4/5] net/e1000: add module EEPROM callbacks for e1000 Zijie Pan
2018-04-24 10:17 ` [dpdk-dev] [PATCH v4 5/5] net/i40e: add module EEPROM callbacks for i40e Zijie Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86b55f0-3287-0b5f-0adc-6cfc278c3c49@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=zijie.pan@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).