From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Chenbo Xia <chenbo.xia@intel.com>,
Ivan Dyukov <i.dyukov@samsung.com>
Cc: dev@dpdk.org, Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/virtio: fix link update in speed feature case
Date: Fri, 29 Oct 2021 12:33:43 +0200 [thread overview]
Message-ID: <a9d33041-9975-e1a6-ab94-1db91d7f86d4@redhat.com> (raw)
In-Reply-To: <20211022131755.932304-1-andrew.rybchenko@oktetlabs.ru>
On 10/22/21 15:17, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
>
> Link update callback reports speed/duplex based on data
> filled on device initialization. This is wrong in case of
> VIRTIO_NET_F_SPEED_DUPLEX is negotiated since link could
> be down at this time. Fix this function to actually
> update the HW data in this case with respect to the fact
> that specifying speed via devarg is a highest priority.
>
> Fixes: 1357b4b36246 ("net/virtio: support Virtio link speed feature")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> drivers/net/virtio/virtio.h | 5 ++++
> drivers/net/virtio/virtio_ethdev.c | 47 +++++++++++++++++++++---------
> 2 files changed, 39 insertions(+), 13 deletions(-)
>
Applied to dpdk-next-virtio/main with suggested change.
Thanks,
Maxime
prev parent reply other threads:[~2021-10-29 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 13:17 Andrew Rybchenko
2021-10-29 9:42 ` Maxime Coquelin
2021-10-29 10:20 ` Andrew Rybchenko
2021-10-29 10:33 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d33041-9975-e1a6-ab94-1db91d7f86d4@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=i.dyukov@samsung.com \
--cc=ivan.ilchenko@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).