From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH 05/10] cmdline: fix port list parsing
Date: Fri, 20 Jun 2025 10:58:46 +0100 [thread overview]
Message-ID: <aFUw1gDuJNuJBnIs@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250619071037.37325-6-david.marchand@redhat.com>
On Thu, Jun 19, 2025 at 09:10:31AM +0200, David Marchand wrote:
> Doing arithmetics with the NULL pointer is undefined.
>
> Caught by UBSan:
>
> ../lib/cmdline/cmdline_parse_portlist.c:40:19: runtime error:
> applying non-zero offset 1 to null pointer
> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
> ../lib/cmdline/cmdline_parse_portlist.c:40:19 in
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/cmdline/cmdline_parse_portlist.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/lib/cmdline/cmdline_parse_portlist.c b/lib/cmdline/cmdline_parse_portlist.c
> index ef6ce223b5..0c07cc02b5 100644
> --- a/lib/cmdline/cmdline_parse_portlist.c
> +++ b/lib/cmdline/cmdline_parse_portlist.c
> @@ -4,6 +4,7 @@
> * All rights reserved.
> */
>
> +#include <stdbool.h>
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> @@ -37,10 +38,11 @@ parse_ports(cmdline_portlist_t *pl, const char *str)
> const char *first, *last;
> char *end;
>
> - for (first = str, last = first;
> - first != NULL && last != NULL;
> - first = last + 1) {
Maybe I'm a little slow this morning, but I can't see how this is actually
a problem. By my understanding, the check for "first != NULL && last !=
NULL" happens before any increment of "first = last + 1", meaning we are
guaranteed that the last is never null when we increment it.
/Bruce
> + if (str == NULL)
> + return 0;
>
> + last = first = str;
> + do {
> last = strchr(first, ',');
>
> errno = 0;
> @@ -65,7 +67,10 @@ parse_ports(cmdline_portlist_t *pl, const char *str)
> return -1;
>
> parse_set_list(pl, ps, pe);
> - }
> + if (last == NULL)
> + break;
> + first = last + 1;
> + } while (true);
>
> return 0;
> }
> --
> 2.49.0
>
next prev parent reply other threads:[~2025-06-20 9:59 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250619071037.37325-1-david.marchand@redhat.com>
2025-06-19 7:10 ` [PATCH 02/10] test/telemetry: fix test calling all commands David Marchand
2025-06-20 9:16 ` Bruce Richardson
2025-06-23 9:54 ` David Marchand
2025-06-19 7:10 ` [PATCH 04/10] eal: fix plugin dir walk David Marchand
2025-06-20 9:19 ` Bruce Richardson
2025-06-23 9:41 ` David Marchand
2025-06-19 7:10 ` [PATCH 05/10] cmdline: fix port list parsing David Marchand
2025-06-20 9:58 ` Bruce Richardson [this message]
2025-06-23 9:40 ` David Marchand
2025-06-23 10:41 ` Bruce Richardson
2025-06-19 7:10 ` [PATCH 06/10] cmdline: fix highest bit " David Marchand
2025-06-20 9:21 ` Bruce Richardson
2025-06-23 9:32 ` David Marchand
2025-06-19 7:10 ` [PATCH 07/10] tailq: fix cast macro for null pointer David Marchand
2025-06-20 9:23 ` Bruce Richardson
2025-06-19 7:10 ` [PATCH 08/10] hash: fix unaligned access in predictable RSS David Marchand
2025-06-19 7:10 ` [PATCH 09/10] stack: fix unaligned accesses on 128-bit David Marchand
[not found] ` <20250623135242.461965-1-david.marchand@redhat.com>
2025-06-23 13:52 ` [PATCH v2 02/10] test/telemetry: fix test calling all commands David Marchand
2025-06-24 15:59 ` Marat Khalili
2025-06-26 8:32 ` David Marchand
2025-06-26 9:51 ` Marat Khalili
2025-07-03 14:09 ` David Marchand
2025-07-03 15:08 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 04/10] eal: fix plugin dir walk David Marchand
2025-06-25 8:43 ` Marat Khalili
2025-07-03 14:27 ` David Marchand
2025-06-23 13:52 ` [PATCH v2 05/10] cmdline: fix port list parsing David Marchand
2025-06-23 14:00 ` Bruce Richardson
2025-06-26 9:32 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 06/10] cmdline: fix highest bit " David Marchand
2025-06-30 15:25 ` Marat Khalili
2025-06-23 13:52 ` [PATCH v2 07/10] tailq: fix cast macro for null pointer David Marchand
2025-06-30 16:06 ` Marat Khalili
2025-07-16 8:25 ` David Marchand
2025-06-23 13:52 ` [PATCH v2 08/10] hash: fix unaligned access in predictable RSS David Marchand
2025-06-30 15:32 ` Bruce Richardson
2025-07-01 8:36 ` Konstantin Ananyev
2025-07-08 7:32 ` David Marchand
2025-07-08 17:58 ` Konstantin Ananyev
2025-07-15 11:57 ` David Marchand
2025-07-15 13:32 ` Konstantin Ananyev
2025-07-15 14:54 ` David Marchand
2025-07-16 6:00 ` Mattias Rönnblom
2025-06-23 13:52 ` [PATCH v2 09/10] stack: fix unaligned accesses on 128-bit David Marchand
2025-06-30 15:33 ` Bruce Richardson
[not found] ` <20250708122823.3406288-1-david.marchand@redhat.com>
2025-07-08 12:28 ` [PATCH v3 02/18] test/telemetry: fix test calling all commands David Marchand
2025-07-08 12:28 ` [PATCH v3 04/18] eal: fix plugin dir walk David Marchand
2025-07-08 12:28 ` [PATCH v3 05/18] cmdline: fix port list parsing David Marchand
2025-07-08 12:28 ` [PATCH v3 06/18] cmdline: fix highest bit " David Marchand
2025-07-08 12:28 ` [PATCH v3 07/18] tailq: fix cast macro for null pointer David Marchand
2025-07-08 12:28 ` [PATCH v3 08/18] hash: fix unaligned access in predictable RSS David Marchand
2025-07-08 12:35 ` Medvedkin, Vladimir
2025-07-08 12:28 ` [PATCH v3 09/18] stack: fix unaligned accesses on 128-bit David Marchand
2025-07-08 15:41 ` Morten Brørup
2025-07-09 8:23 ` Konstantin Ananyev
2025-07-08 12:28 ` [PATCH v3 13/18] graph: fix stats query with no node xstats David Marchand
2025-07-08 12:28 ` [PATCH v3 14/18] graph: fix unaligned access in stats David Marchand
2025-07-15 5:27 ` [EXTERNAL] " Kiran Kumar Kokkilagadda
2025-07-08 12:28 ` [PATCH v3 15/18] eventdev: fix listing timer adapters with telemetry David Marchand
[not found] ` <20250716130212.1736407-1-david.marchand@redhat.com>
2025-07-16 13:01 ` [PATCH v4 02/22] test/telemetry: fix test calling all commands David Marchand
2025-07-16 13:01 ` [PATCH v4 04/22] eal: fix plugin dir walk David Marchand
2025-07-16 13:01 ` [PATCH v4 05/22] cmdline: fix port list parsing David Marchand
2025-07-16 13:01 ` [PATCH v4 06/22] cmdline: fix highest bit " David Marchand
2025-07-16 13:01 ` [PATCH v4 07/22] tailq: fix lookup macro David Marchand
2025-07-16 13:01 ` [PATCH v4 08/22] hash: fix unaligned access in predictable RSS David Marchand
2025-07-16 14:32 ` Konstantin Ananyev
2025-07-16 13:02 ` [PATCH v4 13/22] graph: fix stats query with no node xstats David Marchand
2025-07-16 13:02 ` [PATCH v4 14/22] graph: fix unaligned access in stats David Marchand
2025-07-16 13:02 ` [PATCH v4 15/22] eventdev: fix listing timer adapters with telemetry David Marchand
[not found] ` <20250723133157.159825-1-david.marchand@redhat.com>
2025-07-23 13:31 ` [PATCH v5 02/22] test/telemetry: fix test calling all commands David Marchand
2025-07-23 13:31 ` [PATCH v5 04/22] eal: fix plugin dir walk David Marchand
2025-07-23 13:31 ` [PATCH v5 05/22] cmdline: fix port list parsing David Marchand
2025-07-23 13:31 ` [PATCH v5 06/22] cmdline: fix highest bit " David Marchand
2025-07-23 13:31 ` [PATCH v5 07/22] tailq: fix lookup macro David Marchand
2025-07-23 13:31 ` [PATCH v5 08/22] hash: fix unaligned access in predictable RSS David Marchand
2025-07-23 13:31 ` [PATCH v5 13/22] graph: fix stats query with no node xstats David Marchand
2025-07-23 13:31 ` [PATCH v5 14/22] graph: fix unaligned access in stats David Marchand
2025-07-23 13:31 ` [PATCH v5 15/22] eventdev: fix listing timer adapters with telemetry David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFUw1gDuJNuJBnIs@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).