From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>,
wenzhuo.lu@intel.com, helin.zhang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: enable flex bytes for generic flow API
Date: Tue, 23 May 2017 14:21:02 +0100 [thread overview]
Message-ID: <aa4247fe-ac28-6d9b-7686-a3d96dbfe278@intel.com> (raw)
In-Reply-To: <1495511950-12130-3-git-send-email-qi.z.zhang@intel.com>
On 5/23/2017 4:59 AM, Qi Zhang wrote:
> Add fdir flex byte support for rte_flow APIs.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Hi Qi,
There are a few checkpatch errors for this patch also please find a few
minor syntax issues below.
<...>
> +int
> +ixgbe_fdir_set_flexbytes_offset(struct rte_eth_dev *dev,
> + uint16_t offset)
> +{
> + uint32_t fdirctrl;
> + int i;
> + struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
We don't have "reverse christmas tree declarations", right J
<...>
> +
> + /*Not supported last point for range*/
Spaces around comment.
<...>
> + /**
> + * mask should not be null
> + */
Can have single line comment.
next prev parent reply other threads:[~2017-05-23 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 3:59 [dpdk-dev] [PATCH 1/3] net/ixgbe: remove reduandent code Qi Zhang
2017-05-23 3:59 ` [dpdk-dev] [PATCH 2/3] net/ixgbe: fix fdir mask not be reset Qi Zhang
2017-05-23 3:59 ` [dpdk-dev] [PATCH 3/3] net/ixgbe: enable flex bytes for generic flow API Qi Zhang
2017-05-23 13:21 ` Ferruh Yigit [this message]
2017-05-24 1:25 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa4247fe-ac28-6d9b-7686-a3d96dbfe278@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).