From: "Singh, Aman Deep" <aman.deep.singh@intel.com>
To: Suanming Mou <suanmingm@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Alexander Kozyrev <akozyrev@nvidia.com>,
Yuying Zhang <yuying.zhang@intel.com>, Ori Kam <orika@nvidia.com>
Subject: Re: [PATCH] app/testpmd: fix incorrect flow arguments name
Date: Thu, 6 Oct 2022 13:29:14 +0530 [thread overview]
Message-ID: <ab8befd4-b00e-404a-6c0f-4d7d0fd31957@intel.com> (raw)
In-Reply-To: <20220930113950.833-1-suanmingm@nvidia.com>
On 9/30/2022 5:09 PM, Suanming Mou wrote:
> There should be no spaces in flow command arguments name.
> This commit removes incorrect arguments name in queue based table
> template.
>
> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
> Cc: akozyrev@nvidia.com
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Aman Singh<aman.deep.singh@intel.com>
>
> ---
> app/test-pmd/cmdline_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 148dbc082d..e59d64ffa9 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -2968,7 +2968,7 @@ static const struct token token_list[] = {
> },
> /* Queue arguments. */
> [QUEUE_TEMPLATE_TABLE] = {
> - .name = "template table",
> + .name = "template_table",
> .help = "specify table id",
> .next = NEXT(NEXT_ENTRY(QUEUE_PATTERN_TEMPLATE),
> NEXT_ENTRY(COMMON_TABLE_ID)),
next prev parent reply other threads:[~2022-10-06 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 11:39 Suanming Mou
2022-10-06 7:59 ` Singh, Aman Deep [this message]
2022-10-11 6:55 ` Ori Kam
2022-10-17 7:53 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab8befd4-b00e-404a-6c0f-4d7d0fd31957@intel.com \
--to=aman.deep.singh@intel.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).