From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Andy Pei <andy.pei@intel.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com, stable@dpdk.org
Subject: Re: [PATCH] vdpa/ifc: fix argument compatibility check
Date: Thu, 19 Jan 2023 11:20:11 +0100 [thread overview]
Message-ID: <abd7a2a9-cb4f-e11d-887f-f966e906c11f@redhat.com> (raw)
In-Reply-To: <1669879940-60846-1-git-send-email-andy.pei@intel.com>
On 12/1/22 08:32, Andy Pei wrote:
> "sw_fallback_lm=0" means driver does not provide live migration assistance.
> so hardware assistance is needed to support live migration.
> However registers for live migration in BAR4 are not implemented.
> In the case, we just return error after display some logs.
>
> Fixes: 4c3f55cc23ea ("net/ifc: add LM mode parameter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 49d68ad..9468f66 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -1746,6 +1746,11 @@ struct rte_vdpa_dev_info dev_info[] = {
> goto error;
> }
> internal->sw_lm = sw_fallback_lm;
> + if (!internal->sw_lm && !internal->hw.lm_cfg) {
> + DRV_LOG(ERR, "Device %s does not support HW assist live migration, please enable sw-live-migration!",
> + pci_dev->name);
> + goto error;
> + }
>
> pthread_mutex_lock(&internal_list_lock);
> TAILQ_INSERT_TAIL(&internal_list, list, next);
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-01-19 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 7:32 Andy Pei
2023-01-19 10:20 ` Maxime Coquelin [this message]
2023-02-03 14:48 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abd7a2a9-cb4f-e11d-887f-f966e906c11f@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=andy.pei@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).