From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>,
dev@dpdk.org, beilei.xing@intel.com
Cc: wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix eth pattern parsing
Date: Tue, 4 Apr 2017 13:39:47 +0100 [thread overview]
Message-ID: <ac41bc09-c7bd-47ce-f198-e5cecdc2a626@intel.com> (raw)
In-Reply-To: <1491236049-6747-1-git-send-email-bernard.iremonger@intel.com>
On 4/3/2017 5:14 PM, Bernard Iremonger wrote:
> Handle the following eth patterns:
> eth dst spec aa:bb:cc:dd:ee:ff
> eth dst mask ff:ff:ff:ff:ff:ff
> eth src spec aa:bb:cc:dd:ee:ff
> eth src mask ff:ff:ff:ff:ff:ff
>
> Fixes: d46e85af6b5c ("net/i40e: parse QinQ pattern")
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index 9f541eaff..3fcd31036 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -1772,7 +1772,8 @@ i40e_flow_parse_qinq_pattern(__rte_unused struct rte_eth_dev *dev,
> case RTE_FLOW_ITEM_TYPE_ETH:
> eth_spec = (const struct rte_flow_item_eth *)item->spec;
> eth_mask = (const struct rte_flow_item_eth *)item->mask;
> - if (eth_spec && eth_mask) {
> + if ((eth_spec && eth_mask) ||
> + (eth_spec || eth_mask)) {
Is this check requires both spec and mask to be all zeros? If this is
the real intention, can you please add a comment above check to clarify it.
Also other i40e_flow_parse_xxx_pattern() functions has function comment
to describe expected/valid pattern for the flow rule.
i40e_flow_parse_qinq_pattern() is missing that function comment. Would
you mind adding it, which helps to validate implementation against
intention.
Thanks,
ferruh
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ITEM,
> item,
>
next prev parent reply other threads:[~2017-04-04 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 16:14 Bernard Iremonger
2017-04-04 12:39 ` Ferruh Yigit [this message]
2017-04-04 12:52 ` Iremonger, Bernard
2017-04-05 2:03 ` Xing, Beilei
2017-04-05 8:00 ` Iremonger, Bernard
2017-04-05 14:03 ` [dpdk-dev] [PATCH v2] net/i40e: fix QinQ " Bernard Iremonger
2017-04-06 4:54 ` Xing, Beilei
2017-04-07 16:21 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac41bc09-c7bd-47ce-f198-e5cecdc2a626@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).