From: "Hunt, David" <david.hunt@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] checkpatches: don't assume bash syntax
Date: Wed, 29 Aug 2018 09:56:12 +0100 [thread overview]
Message-ID: <ac9bf37e-03db-918e-c2e3-905b6eaccb10@intel.com> (raw)
In-Reply-To: <20180813154755.6313-1-stephen@networkplumber.org>
Hi Stephen,
On 13/8/2018 4:47 PM, Stephen Hemminger wrote:
> The read -d option is a bash extension and not avaiable in other
> shells. On Debian, /bin/sh is dash and checktpatches would
> fail with:
> ./devtools/checkpatches.sh: 52: read: Illegal option -d
>
> Fix by using awk -e and adding necessary double backslash.
>
> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--snip--
The flavour of awk that's installed by default on Ubuntu is 'mawk' which
does
not seem to have a '-e' option. However, for anyone tryung to run
checkpatch
on Ubuntu with this patch, the quickest workaround is to install 'gawk',
which does have the -e option, then this patch works great.
Rgds,
Dave.
prev parent reply other threads:[~2018-08-29 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 15:47 Stephen Hemminger
2018-08-29 8:56 ` Hunt, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac9bf37e-03db-918e-c2e3-905b6eaccb10@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).