From: "lihuisong (C)" <lihuisong@huawei.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, <dev@dpdk.org>
Cc: <liuyonglong@huawei.com>, <thomas@monjalon.net>
Subject: Re: [PATCH v4 0/5] doc/features: fix some features and add new features
Date: Tue, 28 Nov 2023 12:07:23 +0800 [thread overview]
Message-ID: <acb7e740-2f78-5660-9a2a-aee1c0ce7e17@huawei.com> (raw)
In-Reply-To: <912c84da-d869-b130-3eb6-b55ad2d73f75@huawei.com>
在 2023/11/28 10:09, lihuisong (C) 写道:
>
> 在 2023/11/28 0:44, Ferruh Yigit 写道:
>> On 11/27/2023 2:16 PM, Huisong Li wrote:
>>> The support for setting RSS hash algorithm has been introduced to
>>> 23.11,
>>> but doesn't add feature for it. So this series add this feature to
>>> RSS hash
>>> and perfect RSS other features by the way.
>>>
>>> In addition, serval features or interface, like "set link up/down",
>>> "TM",
>>> "link speeds" and "dump device private information" had beed supported,
>>> but they are absent from the freatures list.
>>>
>>> ---
>>> -v4:
>>> - fix RSS releated feaures description based on Ferruh
>>> - add new features to default.ini
>>> - remove loopback patch.
>>> - move "dump device private information" to "dev ops" block.
>>>
>>> -v3:
>>> - fix description of the patchset cover
>>> - remove '/features' in 'doc/features' tag for every patch.
>>> - add Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>>> - retrigger CI build because of wrong CI warning
>>>
>>> -v2:
>>> - add loopback mode feature.
>>>
>>> Huisong Li (5):
>>> doc: fix the description of RSS related feature
>>> doc: add link up/down feature
>>> doc: add features for link speeds
>>> doc: add Traffic Manager feature
>>> doc: add dump device private information ops
>>>
>> As mentioned before I don't know about adding link speed feature or not,
>> would like to get more comment.
> ok, let us to get more comment.
> it is better that we send a separated patch about link speed feature
> to discuss and get more comment.
> In this way, other patch in this series also go ahead to upload.
> what do you think?
>>
>> But for the new features added, driver .ini files also needs to be
>> updated for that new feature, and drivers support it should mark the
>> support.
> agree.
> I will add "Traffic Manager" feature to driver.ini for the supported
> TM driver.
> But I'm not sure if I am supposed to do this in patch 4/5 or send
> independent patch for every supported driver.
Thinking twice, I will separate this "TM" patch from this series and
send a independent patchset to do this.
Then we can take a look at that series.
> what do you think of that?
>> That is why it is best to start documenting a feature when it is first
>> introduced, otherwise it is more work to update it later.
> agree with you.
> we should remind someone to add it to this feature doc when a new
> feature is introduced.
>>
>> .
> .
next prev parent reply other threads:[~2023-11-28 4:07 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 13:59 [PATCH " Huisong Li
2023-11-23 13:59 ` [PATCH 1/5] doc/features: add RSS hash algorithm feature Huisong Li
2023-11-23 13:59 ` [PATCH 2/5] doc/features: add link up/down feature Huisong Li
2023-11-23 13:59 ` [PATCH 3/5] doc/features: add config interface for speed capabilities Huisong Li
2023-11-23 13:59 ` [PATCH 4/5] doc/features: add Traffic Manager features Huisong Li
2023-11-23 13:59 ` [PATCH 5/5] doc/features: add dump device private information feature Huisong Li
2023-11-23 14:18 ` Thomas Monjalon
2023-11-24 2:03 ` lihuisong (C)
2023-11-24 3:12 ` [PATCH 0/6] doc/features: fix some features and add new features Huisong Li
2023-11-24 3:12 ` [PATCH 1/6] doc/features: add RSS hash algorithm feature Huisong Li
2023-11-24 3:12 ` [PATCH 2/6] doc/features: add link up/down feature Huisong Li
2023-11-24 3:12 ` [PATCH 3/6] doc/features: add features for link speeds Huisong Li
2023-11-24 3:12 ` [PATCH 4/6] doc/features: add Traffic Manager features Huisong Li
2023-11-24 3:12 ` [PATCH 5/6] doc/features: add dump device private information feature Huisong Li
2023-11-24 3:12 ` [PATCH 6/6] doc/features: add feature for loopback mode Huisong Li
2023-11-24 3:24 ` [PATCH 0/6] doc/features: fix some features and add new features fengchengwen
2023-11-25 1:47 ` [PATCH v3 " Huisong Li
2023-11-25 1:47 ` [PATCH v3 1/6] doc: add RSS hash algorithm feature Huisong Li
2023-11-27 12:19 ` Ferruh Yigit
2023-11-27 13:12 ` lihuisong (C)
2023-11-27 15:43 ` Ferruh Yigit
2023-11-27 16:35 ` Ferruh Yigit
2023-11-28 1:34 ` lihuisong (C)
2023-11-28 10:23 ` Ferruh Yigit
2023-11-28 1:21 ` lihuisong (C)
2023-11-28 10:09 ` Ferruh Yigit
2023-11-28 11:29 ` lihuisong (C)
2023-11-28 11:52 ` Ferruh Yigit
2023-11-28 12:46 ` lihuisong (C)
2023-11-25 1:47 ` [PATCH v3 2/6] doc: add link up/down feature Huisong Li
2023-11-27 12:24 ` Ferruh Yigit
2023-11-27 13:16 ` lihuisong (C)
2023-11-25 1:47 ` [PATCH v3 3/6] doc: add features for link speeds Huisong Li
2023-11-25 1:47 ` [PATCH v3 4/6] doc: add Traffic Manager feature Huisong Li
2023-11-25 1:47 ` [PATCH v3 5/6] doc: add dump device private information feature Huisong Li
2023-11-25 1:47 ` [PATCH v3 6/6] doc: add feature for loopback mode Huisong Li
2023-11-27 12:35 ` [PATCH v3 0/6] doc/features: fix some features and add new features Ferruh Yigit
2023-11-27 13:37 ` lihuisong (C)
2023-11-27 16:19 ` Ferruh Yigit
2023-11-27 14:16 ` [PATCH v4 0/5] " Huisong Li
2023-11-27 14:16 ` [PATCH v4 1/5] doc: fix the description of RSS related feature Huisong Li
2023-11-27 16:36 ` Ferruh Yigit
2023-11-27 14:16 ` [PATCH v4 2/5] doc: add link up/down feature Huisong Li
2023-11-27 14:16 ` [PATCH v4 3/5] doc: add features for link speeds Huisong Li
2023-11-27 14:16 ` [PATCH v4 4/5] doc: add Traffic Manager feature Huisong Li
2023-11-27 14:16 ` [PATCH v4 5/5] doc: add dump device private information ops Huisong Li
2023-11-27 16:37 ` Ferruh Yigit
2023-11-27 16:44 ` [PATCH v4 0/5] doc/features: fix some features and add new features Ferruh Yigit
2023-11-28 2:09 ` lihuisong (C)
2023-11-28 4:07 ` lihuisong (C) [this message]
2023-11-27 16:56 ` Ferruh Yigit
2023-11-28 2:23 ` lihuisong (C)
2023-11-28 5:59 ` [PATCH v5 0/3] " Huisong Li
2023-11-28 5:59 ` [PATCH v5 1/3] doc: fix the description of RSS related feature Huisong Li
2023-11-28 13:54 ` Thomas Monjalon
2023-11-28 5:59 ` [PATCH v5 2/3] doc: add link up/down feature Huisong Li
2023-11-28 5:59 ` [PATCH v5 3/3] doc: add dump device private information ops Huisong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acb7e740-2f78-5660-9a2a-aee1c0ce7e17@huawei.com \
--to=lihuisong@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=liuyonglong@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).