From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/virtio: improve offload check performance
Date: Thu, 7 Jun 2018 09:22:13 +0200 [thread overview]
Message-ID: <adaa7519-decf-bbff-90f4-04633f685414@redhat.com> (raw)
In-Reply-To: <20180607045140.GA32696@debian>
On 06/07/2018 06:51 AM, Tiwei Bie wrote:
> On Wed, Jun 06, 2018 at 02:31:28PM +0200, Maxime Coquelin wrote:
>> Instead of checking the multiple Virtio features bits for
>> every packet, let's do the check once at configure time and
>> store it in virtio_hw struct.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
> [...]
>> @@ -270,8 +261,7 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
>> * which is wrong. Below subtract restores correct pkt size.
>> */
>> cookie->pkt_len -= head_size;
>> - /* if offload disabled, it is not zeroed below, do it now */
>
> I think there is no need to remove this comment.
Oh right, that was not intentional.
Will add it again.
> Apart from that,
>
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks,
Maxime
>> - if (offload == 0) {
>> + if (!vq->hw->has_tx_offload) {
>> ASSIGN_UNLESS_EQUAL(hdr->csum_start, 0);
>> ASSIGN_UNLESS_EQUAL(hdr->csum_offset, 0);
>> ASSIGN_UNLESS_EQUAL(hdr->flags, 0);
> [...]
>
prev parent reply other threads:[~2018-06-07 7:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 12:31 [dpdk-dev] [PATCH v2 0/5] net/virtio: Tx path selection and offload improvements Maxime Coquelin
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default Maxime Coquelin
2018-06-07 5:43 ` Tiwei Bie
2018-06-07 7:40 ` Maxime Coquelin
2018-06-07 7:53 ` Tiwei Bie
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 2/5] net/virtio: use simple path for Tx even if Rx mergeable Maxime Coquelin
2018-06-07 5:18 ` Tiwei Bie
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 3/5] net/vhost: improve Tx path selection Maxime Coquelin
2018-06-07 5:13 ` Tiwei Bie
2018-06-07 7:34 ` Maxime Coquelin
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 4/5] net/virtio: don't use simple Rx if TCP LRO or VLAN strip requested Maxime Coquelin
2018-06-07 4:58 ` Tiwei Bie
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 5/5] net/virtio: improve offload check performance Maxime Coquelin
2018-06-07 4:51 ` Tiwei Bie
2018-06-07 7:22 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaa7519-decf-bbff-90f4-04633f685414@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).