From: Declan Doherty <declan.doherty@intel.com>
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: reduce slave starvation on rx poll
Date: Tue, 21 Mar 2017 12:24:00 +0000 [thread overview]
Message-ID: <adc858d5-a2c6-6d9c-fd88-315147b9713f@intel.com> (raw)
In-Reply-To: <20170307223918.33906-1-keith.wiles@intel.com>
Acking the correct version of the patch this time.
On 07/03/2017 10:39 PM, Keith Wiles wrote:
> When polling the bonded ports for RX packets the old driver would
> always start with the first slave in the list. If the requested
> number of packets is filled on the first port in a two port config
> then the second port could be starved or have larger number of
> missed packet errors.
>
> The code attempts to start with a different slave each time RX poll
> is done to help eliminate starvation of slave ports. The effect of
> the previous code was much lower performance for two slaves in the
> bond then just the one slave.
>
> The performance drop was detected when the application can not poll
> the rings of rx packets fast enough and the packets per second for
> two or more ports was at the threshold thoughput of the application.
> At this threshold the slaves would see very little or no drops in
> the case of one slave. Then enable the second slave you would see
> a large drop rate on the two slave bond and reduction in thoughput.
>
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2017-03-21 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 22:39 Keith Wiles
2017-03-21 12:24 ` Declan Doherty [this message]
2017-03-21 13:53 ` Ferruh Yigit
2017-03-21 15:12 ` [dpdk-dev] [PATCH v4] " Keith Wiles
2017-03-21 16:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc858d5-a2c6-6d9c-fd88-315147b9713f@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).