From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>,
dev@dpdk.org, gakhil@marvell.com, hernan.vargas@intel.com
Subject: Re: [PATCH v1 1/1] baseband/acc100: fix to input error related to padding
Date: Tue, 8 Nov 2022 14:41:25 +0100 [thread overview]
Message-ID: <ae46c9e3-ee99-a31b-d8d9-4bb12dbaf338@redhat.com> (raw)
In-Reply-To: <20221107234532.20775-2-nicolas.chautru@intel.com>
On 11/8/22 00:45, Nicolas Chautru wrote:
> Previous commit includes some padding for some cases,
> which may cause input warning from the HW
> which should be safely ignored to avoid false alarm.
>
> Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index 96daef87bc..ba8247d47e 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
> /* Clearing status, it will be set based on response */
> op->status = 0;
>
> - op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
> op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
> op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>
> @@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
> rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n",
> desc, rsp.val, descs_in_tb, desc->req.numCBs);
>
> - op->status |= ((rsp.input_err)
> - ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
> op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
> op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
prev parent reply other threads:[~2022-11-08 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 23:45 [PATCH v1 0/1] baseband/acc100: fix for RC2 Nicolas Chautru
2022-11-07 23:45 ` [PATCH v1 1/1] baseband/acc100: fix to input error related to padding Nicolas Chautru
2022-11-08 5:41 ` [EXT] " Akhil Goyal
2022-11-08 13:41 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae46c9e3-ee99-a31b-d8d9-4bb12dbaf338@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).