From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Matthieu Ternisien d'Ouville <matthieu.tdo@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx: remove link update lock
Date: Mon, 16 Jan 2017 17:19:25 +0000 [thread overview]
Message-ID: <ae98c5ef-6a8d-88dd-592d-081f66eda40e@intel.com> (raw)
In-Reply-To: <20170116140323.GD3779@6wind.com>
On 1/16/2017 2:03 PM, Adrien Mazarguil wrote:
> On Wed, Jan 11, 2017 at 05:44:01PM +0100, Olivier Matz wrote:
>> From: Matthieu Ternisien d'Ouville <matthieu.tdo@6wind.com>
>>
>> Retrieving link status information through the link update callback should
>> be quick and non-blocking.
>>
>> Mellanox PMDs retrieve this information through ioctl() calls on the
>> related kernel netdevice. This appears to take a long time to
>> complete and may cause significant slowdowns in applications.
>>
>> While these system calls cannot be accelerated, removing the lock on the
>> private structure allows applications to perform other control operations
>> from separate threads in the meantime. This function remains safe without
>> locking as it does not write the private structure, it is only used to
>> retrieve the name of the netdevice.
>>
>> Signed-off-by: Matthieu Ternisien d'Ouville <matthieu.tdo@6wind.com>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>> drivers/net/mlx4/mlx4.c | 32 ++++++--------------------------
>> drivers/net/mlx5/mlx5.c | 2 +-
>> drivers/net/mlx5/mlx5.h | 1 -
>> drivers/net/mlx5/mlx5_ethdev.c | 30 ++++++------------------------
>> 4 files changed, 13 insertions(+), 52 deletions(-)
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-01-16 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 16:44 Olivier Matz
2017-01-16 14:03 ` Adrien Mazarguil
2017-01-16 17:19 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae98c5ef-6a8d-88dd-592d-081f66eda40e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=matthieu.tdo@6wind.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).