From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH 0/3] Coverity fixes for DPDK IPC
Date: Fri, 20 Apr 2018 22:40:26 +0800 [thread overview]
Message-ID: <afbeeed3-f254-5e08-1b57-f21a9c813295@intel.com> (raw)
In-Reply-To: <cover.1523978461.git.anatoly.burakov@intel.com>
On 4/17/2018 11:46 PM, Anatoly Burakov wrote:
> This patchset fixes a few Coverity issues introduced
> when various parts of DPDK IPC were added, and explains
> away other reported issues.
>
> Coverity issues fixed:
> - 272595 - return without mutex unlock
> - 272609 - fd leak
>
> Coverity issues intentionally not fixed:
> - 260407 - strcpy into fixed size buffer
> - Both src and dst strings are fixed size, so this is false
> positive
> - Hopefully will be silenced by replacing strcpy with strlcpy
> - 272565 - strcpy into fixed size buffer
> - Same as above
> - 272582 - strcpy into fixed size buffer
> - Same as above
> - 268321 - tainted string
> - Not an issue, we handle errors correctly
> - 272593 - tainted string
> - Same as above
> - 272604 - tainted string
> - Same as above
> - 260410 - not checking return value of rte_thread_setname
> - We intentionally don't care if it fails
> - 272583 - return without mutex unlock
> - Independently discovered and fixed [1]
>
> [1] http://dpdk.org/dev/patchwork/patch/38042/
>
> Anatoly Burakov (3):
> ipc: use strlcpy where applicable
> ipc: fix return without mutex unlock
> ipc: fix resource leak
>
> lib/librte_eal/common/eal_common_proc.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
For this series,
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
Thanks for fixing these issues.
next prev parent reply other threads:[~2018-04-20 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 15:46 Anatoly Burakov
2018-04-17 15:46 ` [dpdk-dev] [PATCH 1/3] ipc: use strlcpy where applicable Anatoly Burakov
2018-04-17 15:46 ` [dpdk-dev] [PATCH 2/3] ipc: fix return without mutex unlock Anatoly Burakov
2018-04-17 15:46 ` [dpdk-dev] [PATCH 3/3] ipc: fix resource leak Anatoly Burakov
2018-04-20 14:40 ` Tan, Jianfeng [this message]
2018-04-23 20:34 ` [dpdk-dev] [PATCH 0/3] Coverity fixes for DPDK IPC Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afbeeed3-f254-5e08-1b57-f21a9c813295@intel.com \
--to=jianfeng.tan@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).