From: Shrikrishna Khare <skhare@shri-linux.eng.vmware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Shrikrishna Khare <skhare@vmware.com>, <yongwang@vmware.com>,
<dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade to version 3
Date: Mon, 6 Mar 2017 09:25:12 -0800 [thread overview]
Message-ID: <alpine.DEB.2.10.1703060920560.24619@shri-linux.eng.vmware.com> (raw)
In-Reply-To: <8019d737-e839-b5e9-53ef-3717db6ab5b3@intel.com>
On Fri, 3 Mar 2017, Ferruh Yigit wrote:
> > Shrikrishna Khare (7):
> > vmxnet3: prepare for version 3 changes
> > vmxnet3: introduce generalized command interface to configure the
> > device
> > vmxnet3: allow variable length transmit data ring buffer
> > vmxnet3: add receive data ring support
> > vmxnet3: add reserved version 3 command
> > vmxnet3: introduce command to register memory region
> > vmxnet3: update to version 3
>
> Hi Shrikrishna,
>
> Can you please update release notes with this change with one or two
> sentences in next version of the patchset?
>
> Also there are helper scripts in dpdk:
> - dpdk/devtools/check-git-log.sh to check patch titles
> - dpdk/devtools/checkpatches.sh (a wrapper to Linux checkpatch.pl)
>
> Both are generating some warnings, can you please check them?
>
> For checkpatches script, it is free to ignore CAMELCASE &
> LONG_LINE_STRING warnings.
Hi Ferruh,
Thank you for the review comments. I have addressed them all and sent v2
patches for review.
In addition to CAMELCASE, there are few LEADING_SPACE warnings that I
have not addressed. This is an existing problem with all the vmxnet3
headers and only fixing it for the lines added by this patch series will
be odd. Hope that is OK. Perhaps a separate patch can fix these style
issues in vmxnet3 header files all at once.
Thanks,
Shri
>
> Thanks,
> ferruh
>
>
>
>
> >
> > drivers/net/vmxnet3/base/vmxnet3_defs.h | 85 ++++++++++++++++--
> > drivers/net/vmxnet3/vmxnet3_ethdev.c | 154 +++++++++++++++++++++++++++++++-
> > drivers/net/vmxnet3/vmxnet3_ethdev.h | 14 +++
> > drivers/net/vmxnet3/vmxnet3_ring.h | 21 +++++
> > drivers/net/vmxnet3/vmxnet3_rxtx.c | 45 ++++++++--
> > 5 files changed, 304 insertions(+), 15 deletions(-)
> >
>
>
next prev parent reply other threads:[~2017-03-06 17:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 21:59 Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 1/7] vmxnet3: prepare for version 3 changes Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 2/7] vmxnet3: introduce generalized command interface to configure the device Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 3/7] vmxnet3: allow variable length transmit data ring buffer Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 4/7] vmxnet3: add receive data ring support Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 5/7] vmxnet3: add reserved version 3 command Shrikrishna Khare
2017-02-25 21:59 ` [dpdk-dev] [PATCH 6/7] vmxnet3: introduce command to register memory region Shrikrishna Khare
2017-03-03 10:46 ` Ferruh Yigit
2017-03-03 10:51 ` Ferruh Yigit
2017-02-25 21:59 ` [dpdk-dev] [PATCH 7/7] vmxnet3: update to version 3 Shrikrishna Khare
2017-03-03 10:57 ` [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade " Ferruh Yigit
2017-03-06 17:25 ` Shrikrishna Khare [this message]
2017-03-07 12:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1703060920560.24619@shri-linux.eng.vmware.com \
--to=skhare@shri-linux.eng.vmware.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=skhare@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).