From: Shrikrishna Khare <skhare@shri-linux.eng.vmware.com>
To: Yong Wang <yongwang@vmware.com>
Cc: "Charles (Chas) Williams" <ciwillia@brocade.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shrikrishna Khare <skhare@vmware.com>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes
Date: Wed, 15 Mar 2017 11:30:03 -0700 [thread overview]
Message-ID: <alpine.DEB.2.10.1703151129110.24619@shri-linux.eng.vmware.com> (raw)
In-Reply-To: <BY2PR05MB2359B3C1E983EBD3C8310A7AAF270@BY2PR05MB2359.namprd05.prod.outlook.com>
On Wed, 15 Mar 2017, Yong Wang wrote:
> > -----Original Message-----
> > From: Charles (Chas) Williams [mailto:ciwillia@brocade.com]
> > Sent: Wednesday, March 15, 2017 5:35 AM
> > To: dev@dpdk.org
> > Cc: Yong Wang <yongwang@vmware.com>; Charles (Chas) Williams
> > <ciwillia@brocade.com>
> > Subject: [PATCH] net/vmxnet3: fix queue size changes
> >
> > If the user reconfigures the queue size, then the previously allocated
> > memzone may potentially be too small. Release the memzone when a
> > queue
> > is released and allocate a new one each time a queue is setup.
> >
> > While here convert to rte_eth_dma_zone_reserve() which does basically
> > the same things as the private function.
> >
> > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
> > implementation")
> >
> > Signed-off-by: Chas Williams <ciwillia@brocade.com>
> > ---
>
> Looks good to me and cc-ing Shrikrishna, the new vmxnet3 pmd maintainer.
Looks good to me too.
Acked-by: Shrikrishna Khare <skhare@vmware.com>
next prev parent reply other threads:[~2017-03-15 18:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 22:41 Charles (Chas) Williams
2017-03-14 16:11 ` Jan Blunck
2017-03-14 16:38 ` Charles (Chas) Williams
2017-03-15 8:18 ` Jan Blunck
2017-03-15 9:45 ` Charles (Chas) Williams
2017-03-15 10:05 ` Jan Blunck
2017-03-15 10:06 ` Charles (Chas) Williams
2017-03-15 12:34 ` Charles (Chas) Williams
2017-03-15 12:35 ` Charles (Chas) Williams
2017-03-15 17:57 ` Yong Wang
2017-03-15 18:30 ` Shrikrishna Khare [this message]
2017-03-15 18:19 ` Jan Blunck
2017-03-16 11:38 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1703151129110.24619@shri-linux.eng.vmware.com \
--to=skhare@shri-linux.eng.vmware.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=skhare@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).