From: Scott Daniels <daniels@research.att.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "ZELEZNIAK, ALEX" <az5157@att.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list
Date: Wed, 19 Oct 2016 22:11:25 -0400 (EDT) [thread overview]
Message-ID: <alpine.LSU.2.20.12.1610192207300.24883@localhost> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093933D40B@shsmsx102.ccr.corp.intel.com>
On Wed, 19 Oct 2016, Lu, Wenzhuo wrote:
> Hi Scott,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of E. Scott Daniels
>> Sent: Thursday, October 20, 2016 6:23 AM
>> To: Zhang, Helin; Iremonger, Bernard
>> Cc: dev@dpdk.org; az5157@att.com; E. Scott Daniels
>> Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list
>>
>> This change prevents the attempt to add a structure which is already on the
>> callback list. If a struct with matching parameters is found on the list, then no
>> action is taken. If a struct with matching parameters is found on the list, then no
>> action is taken.
>>
>> Signed-off-by: E. Scott Daniels <daniels@research.att.com>
> I think the fix itself is good. But 2 things,
> 1, normally we don't create a cover letter for a patch set which only has one patch. Just sending the patch itself is enough.
> 2, ' net/ixgbe: ' in the title is used to describe the component. So the title should be ' lib/ether: prevent duplicate callback on list'.
> Thanks.
Thanks for the advice. My mistake on the component. Is there an easy way
to fix, or does it make sense just to nack this and I'll submit one with
the correct component.
Scott
>
>
next prev parent reply other threads:[~2016-10-20 2:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 22:23 E. Scott Daniels
2016-10-19 22:23 ` E. Scott Daniels
2016-10-20 1:39 ` Lu, Wenzhuo
2016-10-20 2:11 ` Scott Daniels [this message]
2016-10-20 2:19 ` Lu, Wenzhuo
2016-10-20 2:31 ` Scott Daniels
2016-10-20 13:35 ` Scott Daniels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.12.1610192207300.24883@localhost \
--to=daniels@research.att.com \
--cc=az5157@att.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).