DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>, dev@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>,
	Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
	Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [RFC PATCH 1/3] ethdev: update documentation for API to set FEC
Date: Tue, 2 May 2023 15:57:18 +0100	[thread overview]
Message-ID: <b04b993f-de0c-7dc2-59f1-9c8974dd8c6b@amd.com> (raw)
In-Reply-To: <20230428102728.51956-2-denis.pryazhennikov@arknetworks.am>

On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote:
> The documentation for the rte_eth_fec_set() is updated
> to provide more detailed information about how FEC modes are
> handled. It also includes a description of the case when only
> the AUTO bit is set.
> 
> Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
> Acked-by: Ivan Malov <ivan.malov@arknetworks.am>
> Acked-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
> ---
>  lib/ethdev/rte_ethdev.h | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index 99fe9e238b20..0f10ac944061 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -4227,13 +4227,19 @@ int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa);
>   * @param port_id
>   *   The port identifier of the Ethernet device.
>   * @param fec_capa
> - *   A bitmask of allowed FEC modes. If AUTO bit is set, other
> - *   bits specify FEC modes which may be negotiated. If AUTO
> - *   bit is clear, specify FEC modes to be used (only one valid
> - *   mode per speed may be set).
> + *   A bitmask of allowed FEC modes.

ack

> + *   If only the AUTO bit is set, the decision on which FEC
> + *   mode to use will be made by HW/FW or driver.

ack

> + *   If the AUTO bit is set, other bits specify FEC modes
> + *   which may be negotiated. It means that only specified
> + *   FEC modes can be set.

What about some simplification, maybe something like:

"
If the AUTO bit is set with some FEC modes, only specified FEC modes can
be set.
"

> + *   If AUTO bit is clear, specify FEC mode to be used
> + *   (only one valid mode per speed may be set).

ack

> + *   NOFEC will be used if specified FEC modes are not
> + *   supported.

If FEC modes are not supported, I think it is returning error, why
change it?

>   * @return
>   *   - (0) if successful.
> - *   - (-EINVAL) if the FEC mode is not valid.
> + *   - (-EINVAL) if *fec_capa* is not valid.

I think original was correct, if FEC mode is not valid, dev_ops returns
EINVAL, which cause API to return the same.

>   *   - (-ENOTSUP) if underlying hardware OR driver doesn't support.
>   *   - (-EIO) if device is removed.
>   *   - (-ENODEV)  if *port_id* invalid.


  reply	other threads:[~2023-05-02 14:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 10:27 [RFC PATCH 0/3] improve FEC API usage Denis Pryazhennikov
2023-04-28 10:27 ` [RFC PATCH 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-02 14:57   ` Ferruh Yigit [this message]
2023-04-28 10:27 ` [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-02 14:57   ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Denis Pryazhennikov
2023-05-02 15:02   ` Ferruh Yigit
2023-05-04  7:13     ` Denis Pryazhennikov
2023-05-04  7:47       ` Ferruh Yigit
2023-05-08 11:47 ` [RFC PATCH v2 0/3] improve FEC API usage Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 3/3] ethdev: update documentation for API to get FEC Denis Pryazhennikov
2023-05-12 11:57   ` [RFC PATCH v2 0/3] improve FEC API usage Ferruh Yigit
2023-06-07 18:41     ` Ferruh Yigit
2023-06-19 12:36     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b04b993f-de0c-7dc2-59f1-9c8974dd8c6b@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=denis.pryazhennikov@arknetworks.am \
    --cc=dev@dpdk.org \
    --cc=ivan.malov@arknetworks.am \
    --cc=thomas@monjalon.net \
    --cc=viacheslav.galaktionov@arknetworks.am \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).