From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address
Date: Mon, 26 Mar 2018 19:39:00 +0100 [thread overview]
Message-ID: <b06a8115-11c3-20f6-d3c5-88aaf68400f2@intel.com> (raw)
In-Reply-To: <20180227151129.30387-1-olivier.matz@6wind.com>
On 2/27/2018 3:11 PM, Olivier Matz wrote:
> Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> return code is added to notify the caller (librte_ether) if an error
> occurred in the PMD.
>
> The new default MAC address is now copied in dev->data->mac_addrs[0]
> only if the operation is successful.
>
> The patch also updates all the PMDs accordingly.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>
> Hi,
>
> This patch is the following of the discussion we had in this thread:
> https://dpdk.org/dev/patchwork/patch/32284/
>
> I did my best to keep the consistency inside the PMDs. The behavior
> of eth_mac_addr_set() is inspired from other fonctions in the same
> PMD, usually eth_mac_addr_add(). For instance:
> - dpaa and dpaa2 return 0 on error.
> - some PMDs (bnxt, mlx5, ...?) do not return a -errno code (-1 or
> positive values).
> - some PMDs (avf, tap) check if the address is the same and return 0
> in that case. This could go in generic code?
>
> I tried to use the following errors when relevant:
> - -EPERM when a VF is not allowed to do a change
> - -ENOTSUP if the function is not supported
> - -EIO if this is an unknown error from lower layer (hw or sdk)
> - -EINVAL for other unknown errors
>
> Please, PMD maintainers, feel free to comment if you ahve specific
> needs for your driver.
>
> Thanks
> Olivier
>
>
> doc/guides/rel_notes/deprecation.rst | 8 --------
> drivers/net/ark/ark_ethdev.c | 9 ++++++---
> drivers/net/avf/avf_ethdev.c | 12 ++++++++----
> drivers/net/bnxt/bnxt_ethdev.c | 10 ++++++----
> drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++++++--
> drivers/net/dpaa/dpaa_ethdev.c | 4 +++-
> drivers/net/dpaa2/dpaa2_ethdev.c | 6 ++++--
> drivers/net/e1000/igb_ethdev.c | 12 +++++++-----
> drivers/net/failsafe/failsafe_ops.c | 16 +++++++++++++---
> drivers/net/i40e/i40e_ethdev.c | 24 ++++++++++++++---------
> drivers/net/i40e/i40e_ethdev_vf.c | 12 +++++++-----
> drivers/net/ixgbe/ixgbe_ethdev.c | 13 ++++++++-----
> drivers/net/mlx4/mlx4.h | 2 +-
> drivers/net/mlx4/mlx4_ethdev.c | 7 +++++--
> drivers/net/mlx5/mlx5.h | 2 +-
> drivers/net/mlx5/mlx5_mac.c | 7 +++++--
> drivers/net/mrvl/mrvl_ethdev.c | 7 ++++++-
> drivers/net/null/rte_eth_null.c | 3 ++-
> drivers/net/octeontx/octeontx_ethdev.c | 4 +++-
> drivers/net/qede/qede_ethdev.c | 7 +++----
> drivers/net/sfc/sfc_ethdev.c | 14 +++++---------
> drivers/net/szedata2/rte_eth_szedata2.c | 3 ++-
> drivers/net/tap/rte_eth_tap.c | 34 +++++++++++++++++++++------------
> drivers/net/virtio/virtio_ethdev.c | 15 ++++++++++-----
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +++--
> lib/librte_ether/rte_ethdev.c | 7 +++++--
> lib/librte_ether/rte_ethdev_core.h | 2 +-
> test/test/virtual_pmd.c | 3 ++-
> 28 files changed, 159 insertions(+), 97 deletions(-)
ethdev part looks good to me.
Are you planning to have another version for mrvl and sfc comments?
PMD maintainers, please check and provide feedback for your PMD, otherwise the
patch will go in as it is.
Thanks,
ferruh
next prev parent reply other threads:[~2018-03-26 18:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:11 Olivier Matz
2018-03-05 10:29 ` Adrien Mazarguil
2018-03-06 9:37 ` Tomasz Duszynski
2018-03-16 15:41 ` Andrew Rybchenko
2018-03-26 18:39 ` Ferruh Yigit [this message]
2018-03-28 8:24 ` Olivier Matz
2018-04-03 12:41 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2018-04-03 13:02 ` Andrew Rybchenko
2018-04-03 14:57 ` Adrien Mazarguil
2018-04-03 16:26 ` Olivier Matz
2018-04-03 16:19 ` Ferruh Yigit
2018-04-03 16:25 ` Olivier Matz
2018-04-04 8:19 ` Shreyansh Jain
2018-04-06 15:21 ` [dpdk-dev] [PATCH] " Olivier Matz
2018-04-06 15:34 ` Olivier Matz
2018-04-09 8:57 ` Nélio Laranjeiro
2018-04-06 15:34 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2018-04-06 16:03 ` Ferruh Yigit
2018-04-10 13:19 ` Thomas Monjalon
2018-04-11 16:32 ` [dpdk-dev] [PATCH v4] " Olivier Matz
2018-04-11 19:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b06a8115-11c3-20f6-d3c5-88aaf68400f2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).