From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Bie, Tiwei" <tiwei.bie@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get
Date: Fri, 3 Feb 2017 11:52:38 +0000 [thread overview]
Message-ID: <b14f0923-7ded-a3ae-fd73-730f8905348e@intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5608A4@shsmsx102.ccr.corp.intel.com>
On 2/3/2017 6:50 AM, Lu, Wenzhuo wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Monday, January 30, 2017 8:16 PM
>> To: Bie, Tiwei; Lu, Wenzhuo
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get
>>
>> On 1/25/2017 5:24 AM, Tiwei Bie wrote:
>>> On Wed, Jan 25, 2017 at 01:13:32PM +0800, Lu, Wenzhuo wrote:
>>>> Hi Tiwei,
>>>>
>>>>> -----Original Message-----
>>>>> From: Bie, Tiwei
>>>>> Sent: Wednesday, January 25, 2017 11:17 AM
>>>>> To: Lu, Wenzhuo
>>>>> Cc: dev@dpdk.org
>>>>> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up
>>>>> rte_eth_dev_info_get
>>>>>
>>>>> On Wed, Jan 25, 2017 at 10:39:22AM +0800, Wenzhuo Lu wrote:
>>>>>> It'not appropriate to call rte_eth_dev_info_get in PMD, as
>>>>>> rte_eth_dev_info_get need to get info from PMD.
>>>>>> Remove rte_eth_dev_info_get from PMD code and get the info directly.
>>>>>>
>>>>>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>>>>>> ---
>>>>>> drivers/net/ixgbe/ixgbe_ethdev.c | 144
>>>>>> ++++++++++++++++++---------------------
>>>>>> 1 file changed, 68 insertions(+), 76 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>>>>>> b/drivers/net/ixgbe/ixgbe_ethdev.c
>>>>>> index 64ce55a..f14a68b 100644
>>>>>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>>>>>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>>>>>> @@ -4401,17 +4401,17 @@ static int
>>>>> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
>>>>>> int rar_entry;
>>>>>> uint8_t *new_mac = (uint8_t *)(mac_addr);
>>>>>> struct rte_eth_dev *dev;
>>>>>> - struct rte_eth_dev_info dev_info;
>>>>>> + struct rte_pci_device *pci_dev;
>>>>>>
>>>>>> RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
>>>>>>
>>>>>> dev = &rte_eth_devices[port];
>>>>>> - rte_eth_dev_info_get(port, &dev_info);
>>>>>> + pci_dev = IXGBE_DEV_TO_PCI(dev);
>>>>>>
>>>>>> - if (is_ixgbe_pmd(dev_info.driver_name) != 0)
>>>>>> + if (is_ixgbe_pmd(dev->data->drv_name))
>>>>>> return -ENOTSUP;
>>>>>>
>>>>>
>>>>> The return value of is_ixgbe_pmd() is not boolean (actually I think
>>>>> it should be based on its name). If we omit the comparison with 0,
>>>>> the code looks weird. It looks like it'll return -ENOTSUP if the port's driver
>> is ixgbe PMD.
>>>>
>>>> Yes, it’s weird. But what makes it weird is not the missing comparison but
>> the function name.
>>>> Better changing it to ixgbe_pmd_check. How about it?
>>>>
>>>
>>> Yeah, I also prefer to change the helper function itself. But I'm not
>>> good at the naming. I'd like to hear others' opinion. :-)
>>
>> Agree that it looks wrong without 0 comparison.
>>
>> Helper function is checking if the given port is an ixgbe port or not,
>> unfortunately you need to this for PMD specific APIs.
>> So What about is_device_supported(),
>>
>> I agree it is better if it returns bool, and I also think it is better if it gets the
>> rte_eth_dev as input parameter, validating port based on name is API internal
>> knowledge.
>>
>> Also instead of name comparison against fixed string, it can be eth_dev-
>>> driver->pci_drv.name against driver->name. This makes function more
> Thanks for your suggestion. But I don’t get your point here.
> For a specific device, should not the eth_dev->driver->pci_drv.name and the driver->name be the same?
Yes they are same.
But there is a intention to unlink "eth_drv->pci_drv", to better support
non pci devices,
so instead of a PMD directly accessing name through this link, I believe
it is better to use rte_drier->name, which is more generic.
>
>
>> generic, and perhaps this helper function can be moved into ethdev layer,
>> later. For this function needs to get both eth_dev and rte_driver as argument.
>>
>>
>>>
>>> Best regards,
>>> Tiwei Bie
>>>
>
next prev parent reply other threads:[~2017-02-03 11:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 2:39 Wenzhuo Lu
2017-01-25 3:16 ` Tiwei Bie
2017-01-25 5:13 ` Lu, Wenzhuo
2017-01-25 5:24 ` Tiwei Bie
2017-01-30 12:15 ` Ferruh Yigit
2017-02-03 6:50 ` Lu, Wenzhuo
2017-02-03 11:52 ` Ferruh Yigit [this message]
2017-02-01 16:24 ` Ananyev, Konstantin
2017-02-01 17:40 ` Ferruh Yigit
2017-02-01 18:10 ` Ananyev, Konstantin
2017-02-01 18:18 ` Ferruh Yigit
2017-02-03 9:21 ` Iremonger, Bernard
2017-02-03 9:49 ` Ananyev, Konstantin
2017-02-03 10:02 ` Iremonger, Bernard
2017-02-03 12:00 ` Ferruh Yigit
2017-02-06 2:09 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2017-02-06 2:30 ` Tiwei Bie
2017-02-06 2:41 ` Lu, Wenzhuo
2017-02-06 2:51 ` Tiwei Bie
2017-02-06 2:59 ` Lu, Wenzhuo
2017-02-06 3:08 ` Tiwei Bie
2017-02-06 3:45 ` Lu, Wenzhuo
2017-02-06 4:57 ` Tiwei Bie
2017-02-06 5:17 ` Lu, Wenzhuo
2017-02-06 5:26 ` Tiwei Bie
2017-02-07 6:33 ` [dpdk-dev] [PATCH v3] " Wenzhuo Lu
2017-02-07 14:08 ` Ferruh Yigit
2017-02-07 14:09 ` Ferruh Yigit
2017-02-08 0:54 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b14f0923-7ded-a3ae-fd73-730f8905348e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).