From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: enable to set HW debug mask
Date: Tue, 29 Jun 2021 15:02:11 +0000 [thread overview]
Message-ID: <b155bd515b414dddb4327a7ffad42119@intel.com> (raw)
In-Reply-To: <20210629133332.226897-1-haiyue.wang@intel.com>
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Tuesday, June 29, 2021 9:34 PM
> To: dev@dpdk.org
> Cc: david.marchand@redhat.com; Wang, Haiyue <haiyue.wang@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v1] net/ice: enable to set HW debug mask
>
> The HW debug mask is always zero, so user can't enable the related debug
> function like ICE_DBG_XXX etc.
>
> Add the devarg 'hw_debug_mask' to set the function like for ICE_DBG_NVM:
> -a 0000:88:00.0,hw_debug_mask=0x80 --log-level=pmd.net.ice.driver:8
This looks good, please also update the document (ice.rst).
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 09e38590e5..5a18663430 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -26,11 +26,13 @@
> #define ICE_SAFE_MODE_SUPPORT_ARG "safe-mode-support"
> #define ICE_PIPELINE_MODE_SUPPORT_ARG "pipeline-mode-support"
> #define ICE_PROTO_XTR_ARG "proto_xtr"
> +#define ICE_HW_DEBUG_MASK_ARG "hw_debug_mask"
>
> static const char * const ice_valid_args[] = {
> ICE_SAFE_MODE_SUPPORT_ARG,
> ICE_PIPELINE_MODE_SUPPORT_ARG,
> ICE_PROTO_XTR_ARG,
> + ICE_HW_DEBUG_MASK_ARG,
> NULL
> };
>
> @@ -1836,6 +1838,25 @@ parse_bool(const char *key, const char *value,
> void *args)
> return 0;
> }
>
> +static int
> +parse_u64(const char *key, const char *value, void *args) {
> + u64 *num = (u64 *)args;
> + u64 tmp;
> +
> + errno = 0;
> + tmp = strtoull(value, NULL, 16);
> + if (errno) {
> + PMD_DRV_LOG(WARNING, "%s: \"%s\" is not a valid u64",
> + key, value);
> + return -1;
> + }
> +
> + *num = tmp;
> +
> + return 0;
> +}
> +
> static int ice_parse_devargs(struct rte_eth_dev *dev) {
> struct ice_adapter *ad =
> @@ -1872,6 +1893,11 @@ static int ice_parse_devargs(struct rte_eth_dev
> *dev)
> if (ret)
> goto bail;
>
> + ret = rte_kvargs_process(kvlist, ICE_HW_DEBUG_MASK_ARG,
> + &parse_u64, &ad->hw.debug_mask);
> + if (ret)
> + goto bail;
> +
> bail:
> rte_kvargs_free(kvlist);
> return ret;
> @@ -5306,6 +5332,7 @@ RTE_PMD_REGISTER_PCI(net_ice, rte_ice_pmd);
> RTE_PMD_REGISTER_PCI_TABLE(net_ice, pci_id_ice_map);
> RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* igb_uio | uio_pci_generic |
> vfio-pci"); RTE_PMD_REGISTER_PARAM_STRING(net_ice,
> + ICE_HW_DEBUG_MASK_ARG "=0xXXX"
> ICE_PROTO_XTR_ARG
> "=[queue:]<vlan|ipv4|ipv6|ipv6_flow|tcp|ip_offset>"
> ICE_SAFE_MODE_SUPPORT_ARG "=<0|1>"
> ICE_PIPELINE_MODE_SUPPORT_ARG "=<0|1>");
> --
> 2.32.0
next prev parent reply other threads:[~2021-06-29 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 13:33 Haiyue Wang
2021-06-29 15:02 ` Zhang, Qi Z [this message]
2021-06-29 16:40 ` [dpdk-dev] [PATCH v2] " Haiyue Wang
2021-06-30 3:59 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b155bd515b414dddb4327a7ffad42119@intel.com \
--to=qi.z.zhang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).