From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix the param string
Date: Mon, 30 Jul 2018 10:43:37 +0200 [thread overview]
Message-ID: <b16511e0-cbf6-0e65-df5a-dd6c6068f8b3@redhat.com> (raw)
In-Reply-To: <20180730082804.20143-1-tiwei.bie@intel.com>
On 07/30/2018 10:28 AM, Tiwei Bie wrote:
> Add the missing param "server" to param string.
> Also add the missing spaces after params.
>
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> index 5ee59d5e5..525d16cab 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
> "cq=<int> "
> "queue_size=<int> "
> "queues=<int> "
> - "iface=<string>"
> - "mrg_rxbuf=<0|1>"
> + "iface=<string> "
> + "server=<0|1> "
> + "mrg_rxbuf=<0|1> "
> "in_order=<0|1>");
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks!
Maxime
next prev parent reply other threads:[~2018-07-30 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 8:28 Tiwei Bie
2018-07-30 8:43 ` Maxime Coquelin [this message]
2018-08-01 2:06 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16511e0-cbf6-0e65-df5a-dd6c6068f8b3@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).