From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: David Marchand <david.marchand@redhat.com>,
David Hunt <david.hunt@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
ci@dpdk.org
Subject: Re: [dpdk-ci] [dpdk-stable] [PATCH v1 1/1] test/distributor: prevent return buffer overload
Date: Fri, 29 Jan 2021 13:36:58 +0100 [thread overview]
Message-ID: <b16f5c2a-b0c8-7e88-1ec9-f8a4cedc058b@partner.samsung.com> (raw)
In-Reply-To: <CAJFAV8wJvMZCMqjrb2VPnZgw6A_6sYpeRERLjF+8ZJ+9LqMWsQ@mail.gmail.com>
Thank you guys!
W dniu 29.01.2021 o 09:03, David Marchand pisze:
> On Thu, Jan 28, 2021 at 3:10 PM David Marchand
> <david.marchand@redhat.com> wrote:
>> On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski
>> <l.wojciechow@partner.samsung.com> wrote:
>>> The distributor library implementation uses a cyclic queue to store
>>> packets returned from workers. These packets can be later collected
>>> with rte_distributor_returned_pkts() call.
>>> However the queue has limited capacity. It is able to contain only
>>> 127 packets (RTE_DISTRIB_RETURNS_MASK).
>>>
>>> Big burst tests sent 1024 packets in 32 packets bursts without waiting
>>> until they are processed by the distributor. In case when tests were
>>> run with big number of worker threads, it happened that more than
>>> 127 packets were returned from workers and put into cyclic queue.
>>> This caused packets to be dropped by the queue, making them impossible
>>> to be collected later with rte_distributor_returned_pkts() calls.
>>> However the test waited for all packets to be returned infinitely.
>>>
>>> This patch fixes the big burst test by not allowing more than
>>> queue capacity packets to be processed at the same time, making
>>> impossible to drop any packets.
>>> It also cleans up duplicated code in the same test.
>>>
>>> Bugzilla ID: 612
>>> Fixes: c0de0eb82e40 ("distributor: switch over to new API")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
>> Tested-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: David Hunt <david.hunt@intel.com>
>
> Applied, thanks Lukasz.
>
> This should fix the issue seen at UNH on the ARM server.
>
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com
prev parent reply other threads:[~2021-01-29 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210119035920eucas1p15da5a04b73d19e63287dc14905d765f2@eucas1p1.samsung.com>
[not found] ` <20210119035910.8324-1-l.wojciechow@partner.samsung.com>
2021-01-19 8:44 ` [dpdk-ci] [dpdk-dev] [PATCH v1 0/1] distributor test fix David Marchand
2021-01-19 13:06 ` Lukasz Wojciechowski
2021-01-28 13:34 ` David Marchand
[not found] ` <20210119035910.8324-2-l.wojciechow@partner.samsung.com>
[not found] ` <CAJFAV8ws=mCTFF6hQQ8kUFRxuR8QYGzB7ubMFRBDCiU=JmEnZQ@mail.gmail.com>
2021-01-29 8:03 ` [dpdk-ci] [dpdk-stable] [PATCH v1 1/1] test/distributor: prevent return buffer overload David Marchand
2021-01-29 12:36 ` Lukasz Wojciechowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16f5c2a-b0c8-7e88-1ec9-f8a4cedc058b@partner.samsung.com \
--to=l.wojciechow@partner.samsung.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).