From: Remy Horton <remy.horton@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Ivan Malov <ivan.malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH] net/sfc: add support for xstats retrieval by ID
Date: Wed, 12 Jul 2017 15:18:42 +0100 [thread overview]
Message-ID: <b185298f-327d-dc76-14f1-f624814b0e88@intel.com> (raw)
In-Reply-To: <1499528715-1510-1-git-send-email-arybchenko@solarflare.com>
On 08/07/2017 16:45, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
[..]
Reviewed-by: Remy Horton <remy.horton@intel.com>
> + rc = sfc_port_update_mac_stats(sa);
> + if (rc != 0) {
> + SFC_ASSERT(rc > 0);
> + ret = -rc;
sfc_port_update_mac_stats() really ought to be returning -EINVAL or
-ENOMEM rather than EINVAL/ENOMEM then doing a negation here.
Other than that, code seems OK..
next prev parent reply other threads:[~2017-07-12 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 15:45 Andrew Rybchenko
2017-07-12 14:18 ` Remy Horton [this message]
2017-07-12 14:36 ` Andrew Rybchenko
2017-07-18 8:33 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b185298f-327d-dc76-14f1-f624814b0e88@intel.com \
--to=remy.horton@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).