From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Yao, Lei A" <lei.a.yao@intel.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"sodey@sonusnet.com" <sodey@sonusnet.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support
Date: Thu, 30 Mar 2017 13:34:10 +0200 [thread overview]
Message-ID: <b285e11b-76c7-cfd7-78b1-3b255f0bc580@redhat.com> (raw)
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A175FB5@shsmsx102.ccr.corp.intel.com>
Hi Lei,
On 03/28/2017 07:39 AM, Yao, Lei A wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin
>> Sent: Monday, March 13, 2017 12:34 AM
>> To: aconole@redhat.com; sodey@sonusnet.com;
>> yuanhan.liu@linux.intel.com; Tan, Jianfeng <jianfeng.tan@intel.com>;
>> thomas.monjalon@6wind.com; dev@dpdk.org
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support
>>
>> This series adds support to new Virtio's MTU feature[1]. The MTU
>> value is set via QEMU parameters.
>>
>> If the feature is negotiated (i.e supported by both host and guest,
>> and valid MTU value is set in QEMU via its host_mtu parameter), QEMU
>> shares the configured MTU value throught dedicated Vhost protocol
>> feature.
>>
>> On vhost side, the value is stored in the virtio_net structure, and
>> made available to the application thanks to new vhost lib's
>> rte_vhost_get_mtu() function.
>>
>> To be able to set eth_dev's MTU value at the right time, i.e. to call
>> rte_vhost_get_mtu() just after Virtio features have been negotiated
>> and before the device is really started, a new vhost flag has been
>> introduced (VIRTIO_DEV_READY), because the VIRTIO_DEV_RUNNING flag is
>> set too late (after .new_device() ops is called).
>>
>> Regarding valid MTU values, the maximum MTU value accepted on vhost
>> side is 65535 bytes, as defined in Virtio Spec and supported in
>> Virtio-net Kernel driver. But in Virtio PMD, current maximum frame
>> size is 9728 bytes (~9700 bytes MTU). So maximum MTU size accepted in
>> Virtio PMD is the minimum between ~9700 bytes and host's MTU.
>>
>> Finally, this series also adds MTU value printing in testpmd's
>> "show port info" command when non-zero.
>>
>> This series target v17.05 release.
>>
>> Cheers,
>> Maxime
>>
>> [1]: https://lists.oasis-open.org/archives/virtio-dev/201609/msg00128.html
>>
>> Changes since v1:
>> -----------------
>> * Rebased on top of v17.02
>> * Virtio PMD: ensure MTU value is valid before ack'ing the feature (Aaron)
>> * Vhost lib/PMD: Remove MTU setting API/op (Yuanhan)
>>
>> Changes since v2:
>> -----------------
>> * Update release notes (Thomas)
>> * s/rte_vhost_mtu_get/rte_vhost_get_mtu/ (Yuanhan)
>> * Use %"PRIu64" instead of %lu (Yuanhan)
>> * Add rte_vhost_get_mtu in rte_vhost_version.map
>>
>> Maxime Coquelin (9):
>> vhost: Enable VIRTIO_NET_F_MTU feature
>> vhost: vhost-user: Add MTU protocol feature support
>> vhost: Add new ready status flag
>> vhost: Add API to get MTU value
>> vhost: export MTU value
>> net/vhost: Fill rte_eth_dev's MTU property
>> net/virtio: Add MTU feature support
>> doc: announce Virtio and Vhost MTU support
>> app/testpmd: print MTU value in show port info
>>
>> app/test-pmd/config.c | 5 ++++
>> doc/guides/nics/features/virtio.ini | 1 +
>> doc/guides/rel_notes/release_17_05.rst | 8 ++++++
>> drivers/net/vhost/rte_eth_vhost.c | 2 ++
>> drivers/net/virtio/virtio_ethdev.c | 45
>> ++++++++++++++++++++++++++++++++--
>> drivers/net/virtio/virtio_ethdev.h | 3 ++-
>> drivers/net/virtio/virtio_pci.h | 3 +++
>> lib/librte_vhost/rte_vhost_version.map | 7 ++++++
>> lib/librte_vhost/rte_virtio_net.h | 15 ++++++++++++
>> lib/librte_vhost/vhost.c | 22 ++++++++++++++++-
>> lib/librte_vhost/vhost.h | 9 ++++++-
>> lib/librte_vhost/vhost_user.c | 44 +++++++++++++++++++++++++++---
>> ---
>> lib/librte_vhost/vhost_user.h | 5 +++-
>> 13 files changed, 156 insertions(+), 13 deletions(-)
>>
>> --
>> 2.9.3
> Hi, Maxime
>
> If I want have a try for this MTU function, is there any specific requirement for the settings?
> Such as the qemu version, kernel version or any others? Looks like this feature are very new
> in Qemu and linux side.
> Thanks a lot!
Sorry, for the delay.
You need QEMU v2.9.0-rc at least, as this is not in v2.8?
Regarding the Kernel, there are no version dependency for the host.
For the guest, this is only if you use the Kernel virtio-net driver.
In this case, your guest Kernel should be at least v4.10.
Regards,
Maxime
prev parent reply other threads:[~2017-03-30 11:34 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 14:28 [dpdk-dev] [PATCH 0/7] " Maxime Coquelin
2017-02-13 14:28 ` [dpdk-dev] [PATCH 1/7] vhost: Enable VIRTIO_NET_F_MTU feature Maxime Coquelin
2017-02-13 14:28 ` [dpdk-dev] [PATCH 2/7] vhost: vhost-user: Add MTU protocol feature support Maxime Coquelin
2017-02-13 14:28 ` [dpdk-dev] [PATCH 3/7] vhost: Add new ready status flag Maxime Coquelin
2017-02-13 14:28 ` [dpdk-dev] [PATCH 4/7] vhost: Add API to get/set MTU value Maxime Coquelin
2017-02-13 14:28 ` [dpdk-dev] [PATCH 5/7] net/vhost: Implement mtu_set callback Maxime Coquelin
2017-02-13 14:28 ` [dpdk-dev] [PATCH 6/7] net/virtio: Add MTU feature support Maxime Coquelin
2017-02-16 19:31 ` Aaron Conole
2017-02-16 21:17 ` Maxime Coquelin
2017-02-13 14:28 ` [dpdk-dev] [PATCH 7/7] app/testpmd: print MTU value in show port info Maxime Coquelin
2017-02-23 7:10 ` [dpdk-dev] [PATCH 0/7] virtio/vhost: Add MTU feature support Yuanhan Liu
2017-03-01 7:44 ` Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 " Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 1/7] vhost: Enable VIRTIO_NET_F_MTU feature Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 2/7] vhost: vhost-user: Add MTU protocol feature support Maxime Coquelin
2017-03-08 2:31 ` Yuanhan Liu
2017-03-12 10:24 ` Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 3/7] vhost: Add new ready status flag Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 4/7] vhost: Add API to get MTU value Maxime Coquelin
2017-03-08 2:45 ` Yuanhan Liu
2017-03-12 10:23 ` Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 5/7] net/vhost: Fill rte_eth_dev's MTU property Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 6/7] net/virtio: Add MTU feature support Maxime Coquelin
2017-03-06 8:27 ` [dpdk-dev] [PATCH v2 7/7] app/testpmd: print MTU value in show port info Maxime Coquelin
2017-03-07 21:57 ` [dpdk-dev] [PATCH v2 0/7] virtio/vhost: Add MTU feature support Thomas Monjalon
2017-03-12 10:00 ` Maxime Coquelin
2017-03-12 16:33 ` [dpdk-dev] [PATCH v3 0/9] " Maxime Coquelin
2017-03-12 16:33 ` [dpdk-dev] [PATCH v3 1/9] vhost: Enable VIRTIO_NET_F_MTU feature Maxime Coquelin
2017-03-12 16:33 ` [dpdk-dev] [PATCH v3 2/9] vhost: vhost-user: Add MTU protocol feature support Maxime Coquelin
2017-03-12 16:34 ` [dpdk-dev] [PATCH v3 3/9] vhost: Add new ready status flag Maxime Coquelin
2017-03-12 16:34 ` [dpdk-dev] [PATCH v3 4/9] vhost: Add API to get MTU value Maxime Coquelin
2017-03-16 8:00 ` Yuanhan Liu
2017-03-16 11:37 ` Maxime Coquelin
2017-03-17 5:32 ` Yuanhan Liu
2017-03-17 9:59 ` Maxime Coquelin
2017-03-20 8:42 ` Yuanhan Liu
2017-03-12 16:34 ` [dpdk-dev] [PATCH v3 5/9] vhost: export " Maxime Coquelin
2017-03-12 16:34 ` [dpdk-dev] [PATCH v3 6/9] net/vhost: Fill rte_eth_dev's MTU property Maxime Coquelin
2017-03-12 16:34 ` [dpdk-dev] [PATCH v3 7/9] net/virtio: Add MTU feature support Maxime Coquelin
2017-04-05 4:52 ` Tan, Jianfeng
2017-04-05 7:11 ` Maxime Coquelin
2017-04-05 9:42 ` Tan, Jianfeng
2017-04-05 13:54 ` Maxime Coquelin
2017-04-05 14:50 ` Tan, Jianfeng
2017-04-07 16:40 ` Maxime Coquelin
2017-04-10 6:48 ` Tan, Jianfeng
2017-03-12 16:34 ` [dpdk-dev] [PATCH v3 8/9] doc: announce Virtio and Vhost MTU support Maxime Coquelin
2017-03-12 16:34 ` [dpdk-dev] [PATCH v3 9/9] app/testpmd: print MTU value in show port info Maxime Coquelin
2017-03-22 8:58 ` [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support Yuanhan Liu
2017-03-22 9:03 ` Maxime Coquelin
2017-03-28 5:39 ` Yao, Lei A
2017-03-30 11:34 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b285e11b-76c7-cfd7-78b1-3b255f0bc580@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=lei.a.yao@intel.com \
--cc=sodey@sonusnet.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).