From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com
Subject: Re: [dpdk-dev] [PATCH] net/thunderx: use rte version of byteorder.h
Date: Fri, 7 Apr 2017 12:59:34 +0100 [thread overview]
Message-ID: <b292f66e-1afb-0758-d21c-10ed881384af@intel.com> (raw)
In-Reply-To: <20170406160651.15432-1-jerin.jacob@caviumnetworks.com>
On 4/6/2017 5:06 PM, Jerin Jacob wrote:
> The base code was using native GCC macros
> for endian detection. Change to portable
> rte_byteorder.h based endian detection.
>
> Fixes: 262d43fe20ee ("net/thunderx/base: add HW register definitions")
>
> Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
There is one more __BYTE_ORDER__ usage [1], is it kept intentional?
[1]
$ git grep __BYTE_ORDER__ drivers/net/thunderx/
drivers/net/thunderx/base/nicvf_mbox.c:#if __BYTE_ORDER__ ==
__ORDER_BIG_ENDIAN__
next prev parent reply other threads:[~2017-04-07 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 16:06 Jerin Jacob
2017-04-07 11:59 ` Ferruh Yigit [this message]
2017-04-10 19:44 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2017-04-11 10:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b292f66e-1afb-0758-d21c-10ed881384af@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).