From: "Laatz, Kevin" <kevin.laatz@intel.com>
To: Sean Morrissey <sean.morrissey@intel.com>, dev@dpdk.org
Cc: harry.vanhaaren@intel.com, john.oloughlin@intel.com,
marko.kovacevic@intel.com, ciara.power@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
Date: Fri, 19 Jul 2019 11:04:17 +0100 [thread overview]
Message-ID: <b2a979e3-4e51-ce1a-9f9e-8f6d9edaaec0@intel.com> (raw)
In-Reply-To: <20190715105434.18581-1-sean.morrissey@intel.com>
On 15/07/2019 11:54, Sean Morrissey wrote:
> Added telemetry to EAL long options so that when
> --telemetry is passed as an EAL arg that there is
> no unrecognized argument error message printed.
>
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Cc: ciara.power@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> ---
> lib/librte_eal/common/eal_common_options.c | 3 +++
> lib/librte_eal/common/eal_options.h | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 512d5088e..24e36cf23 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -81,6 +81,9 @@ eal_long_options[] = {
> {OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM },
> {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
> {OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
> +#ifdef RTE_LIBRTE_TELEMETRY
> + {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM },
> +#endif
> {0, 0, NULL, 0 }
> };
>
> diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
> index 9855429e5..e4c8e25c2 100644
> --- a/lib/librte_eal/common/eal_options.h
> +++ b/lib/librte_eal/common/eal_options.h
> @@ -69,6 +69,10 @@ enum {
> OPT_IOVA_MODE_NUM,
> #define OPT_MATCH_ALLOCATIONS "match-allocations"
> OPT_MATCH_ALLOCATIONS_NUM,
> +#ifdef RTE_LIBRTE_TELEMETRY
> + #define OPT_TELEMETRY "telemetry"
> + OPT_TELEMETRY_NUM,
> +#endif
> OPT_LONG_MAX_NUM
> };
>
LGTM, thanks!
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
next prev parent reply other threads:[~2019-07-19 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 10:54 Sean Morrissey
2019-07-19 10:04 ` Laatz, Kevin [this message]
2019-07-22 16:40 ` Thomas Monjalon
[not found] <20190711144017.23081-1-sean.morrissey@intel.com>
2019-07-11 15:33 ` OLoughlin, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a979e3-4e51-ce1a-9f9e-8f6d9edaaec0@intel.com \
--to=kevin.laatz@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=harry.vanhaaren@intel.com \
--cc=john.oloughlin@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=sean.morrissey@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).