From: Ivan Dyukov <i.dyukov@samsung.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
yliu@fridaylinux.org, dev@dpdk.org
Cc: i.maximets@samsung.com, heetae82.ahn@samsung.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: fix checking of device features
Date: Thu, 29 Jun 2017 09:07:41 +0300 [thread overview]
Message-ID: <b2b02137-8c73-cfa0-ee77-40ff8ada53cf@samsung.com> (raw)
In-Reply-To: <3b44a715-612d-2ef7-aac2-15f74ac4aa07@redhat.com>
On 06/28/2017 03:54 PM, Maxime Coquelin wrote:
>
>
> On 06/28/2017 02:40 PM, Ivan Dyukov wrote:
>> To compare enabled features in current device we must use bit
>> mask instead of bit position.
>>
>> CC: stable@dpdk.org
>> Fixes: c843af3aa13e ("vhost: access header only")
>>
>> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
>> ---
>> lib/librte_vhost/virtio_net.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> Thanks for the fix Ivan, and sorry for introducing this bug.
> Out of curiosity, did you noticed it because it broke offloading,
> or just by code review?
I didn't see any breakages. It's just code review.
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
>> diff --git a/lib/librte_vhost/virtio_net.c
>> b/lib/librte_vhost/virtio_net.c
>> index ebfda1c..4fae4c1 100644
>> --- a/lib/librte_vhost/virtio_net.c
>> +++ b/lib/librte_vhost/virtio_net.c
>> @@ -601,9 +601,11 @@ static inline bool
>> virtio_net_with_host_offload(struct virtio_net *dev)
>> {
>> if (dev->features &
>> - (VIRTIO_NET_F_CSUM | VIRTIO_NET_F_HOST_ECN |
>> - VIRTIO_NET_F_HOST_TSO4 | VIRTIO_NET_F_HOST_TSO6 |
>> - VIRTIO_NET_F_HOST_UFO))
>> + ((1ULL << VIRTIO_NET_F_CSUM) |
>> + (1ULL << VIRTIO_NET_F_HOST_ECN) |
>> + (1ULL << VIRTIO_NET_F_HOST_TSO4) |
>> + (1ULL << VIRTIO_NET_F_HOST_TSO6) |
>> + (1ULL << VIRTIO_NET_F_HOST_UFO)))
>> return true;
>> return false;
>>
>
>
>
>
next prev parent reply other threads:[~2017-06-29 6:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170628124049eucas1p1688178d88249ae416d653abfc19d0478@eucas1p1.samsung.com>
2017-06-28 12:40 ` Ivan Dyukov
2017-06-28 12:54 ` Maxime Coquelin
2017-06-29 6:07 ` Ivan Dyukov [this message]
2017-06-29 7:21 ` Maxime Coquelin
2017-06-29 7:37 ` Maxime Coquelin
2017-06-29 6:13 ` [dpdk-stable] [dpdk-dev] " Tan, Jianfeng
2017-06-29 7:27 ` Maxime Coquelin
2017-06-29 8:05 ` Tan, Jianfeng
2017-07-01 23:36 ` [dpdk-stable] " Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b02137-8c73-cfa0-ee77-40ff8ada53cf@samsung.com \
--to=i.dyukov@samsung.com \
--cc=dev@dpdk.org \
--cc=heetae82.ahn@samsung.com \
--cc=i.maximets@samsung.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).