From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, techboard@dpdk.org
Subject: Re: [PATCH] bus/vdev: automatically add eth alias for net drivers
Date: Thu, 20 Oct 2022 12:51:47 +0100 [thread overview]
Message-ID: <b30c1c78-2885-7bac-b7d8-222900252cd2@amd.com> (raw)
In-Reply-To: <Y1ELRWEt01AGpJfd@bricha3-MOBL.ger.corp.intel.com>
On 10/20/2022 9:48 AM, Bruce Richardson wrote:
> On Thu, Oct 20, 2022 at 10:23:27AM +0200, Thomas Monjalon wrote:
>> 19/10/2022 15:20, Bruce Richardson:
>>> On Wed, Oct 19, 2022 at 02:11:18PM +0100, Bruce Richardson wrote:
>>>> For historical reasons, a number of net vdev drivers also add a driver
>>>> alias using the "eth_" prefix. Since this is done on a per-driver basis,
>>>> the use of the alias in inconsistent and is spread across multiple
>>>> files. We can remove the per-driver aliases by just adding the alias
>>>> automatically at the vdev bus level.
>>>>
>>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>>> ---
>>>> drivers/bus/vdev/vdev.c | 6 ++++++
>>>> 1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
>>>> index f5b43f1930..bfd7ce60c1 100644
>>>> --- a/drivers/bus/vdev/vdev.c
>>>> +++ b/drivers/bus/vdev/vdev.c
>>>> @@ -54,6 +54,12 @@ static rte_spinlock_t vdev_custom_scan_lock = RTE_SPINLOCK_INITIALIZER;
>>>> void
>>>> rte_vdev_register(struct rte_vdev_driver *driver)
>>>> {
>>>> + /* For net driver vdevs, add an automatic alias using "eth" prefix */
>>>> + if (strncmp(driver->driver.name, "net_", 4) == 0 && driver->driver.alias == NULL) {
>>>> + char *alias = strdup(driver->driver.name);
>>>> + memcpy(alias, "eth_", 4);
>>>> + driver->driver.alias = alias;
>>>> + }
>>>> TAILQ_INSERT_TAIL(&vdev_driver_list, driver, next);
>>>> }
>>>>
>>>
>>> As a self-review comment, I realise this solution has got an issue that it
>>> leaks memory if drivers are constantly being registered or unregistered. I
>>> find it hard to see situations where this can occur, but it is a potential
>>> issue.
>>>
>>> A second solution that does not have this problem is to move the aliasing
>>> to EAL, as below:
>>
>> Honestly I think the status quo is OK:
>> We have some aliases in some PMD for some historical reason
>> and everybody looks OK with that. Isn't it?
>>
>
> Well, the inconsistency bugs me a little, but if others feel the status quo
> is ok, I'm ok with that.
In my perspective this is for cleanup, and new PMDs keep adding alias
because they are copying from existing drivers.
Except from above there is no harm to have alias.
next prev parent reply other threads:[~2022-10-20 11:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 13:34 [PATCH] drivers/net: remove alias for virtual devices Ferruh Yigit
2022-09-21 14:26 ` Thomas Monjalon
2022-09-21 14:43 ` Ferruh Yigit
2022-09-21 14:49 ` Bruce Richardson
2022-10-19 13:13 ` Bruce Richardson
2022-11-06 10:43 ` Andrew Rybchenko
2022-10-19 13:11 ` [PATCH] bus/vdev: automatically add eth alias for net drivers Bruce Richardson
2022-10-19 13:20 ` Bruce Richardson
2022-10-20 8:23 ` Thomas Monjalon
2022-10-20 8:48 ` Bruce Richardson
2022-10-20 11:51 ` Ferruh Yigit [this message]
2022-10-27 7:58 ` David Marchand
2022-10-27 8:35 ` Ferruh Yigit
2023-01-12 11:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b30c1c78-2885-7bac-b7d8-222900252cd2@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).