From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1
Date: Thu, 6 Jul 2017 10:58:29 +0100 [thread overview]
Message-ID: <b3307161-7163-c212-69ed-cae0e7203b2e@intel.com> (raw)
In-Reply-To: <d05fed3d55738e871b22d594a6890d497b75a5a9.1499278209.git.yskoh@mellanox.com>
On 7/5/2017 7:12 PM, Yongseok Koh wrote:
> To make vectorized burst routines enabled, it is required to run on x86_64
> architecture which can support at least SSE4.1. If all the conditions are
> met, the vectorized burst functions are enabled automatically. The decision
> is made individually on RX and TX. There's no PMD option to make a
> selection.
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Hi Yongseok,
clang [2] is producing following build error [1], can you please check?
Thanks,
ferruh
[1]
.../dpdk/drivers/net/mlx5/mlx5_rxtx_vec_sse.c:686:23: error: cannot
convert between vector values of different size ('__m128i' (vector of 2
'long long' values) and 'unsigned long')
invalid_mask = zero | ((mcqe_n - pos) * sizeof(uint16_t)
* 8);
~~~~ ^
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../dpdk/drivers/net/mlx5/mlx5_rxtx_vec_sse.c:1055:15: error: cannot
convert between vector values of different size ('__m128i' (vector of 2
'long long' values) and 'unsigned long')
mask = zero | ((pkts_n - pos) * sizeof(uint16_t) * 8);
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../dpdk/drivers/net/mlx5/mlx5_rxtx_vec_sse.c:1163:15: error: cannot
convert between vector values of different size ('__m128i' (vector of 2
'long long' values) and 'unsigned long')
mask = zero | (comp_idx * sizeof(uint16_t) * 8);
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../dpdk/drivers/net/mlx5/mlx5_rxtx_vec_sse.c:1172:15: error: cannot
convert between vector values of different size ('__m128i' (vector of 2
'long long' values) and 'unsigned long')
mask = zero | (n * sizeof(uint16_t) * 8);
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
4 errors generated.
[2]
ICC is giving build error for same lines, I assume fixing clang will fix
the ICC,
next prev parent reply other threads:[~2017-07-06 9:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 23:03 [dpdk-dev] [PATCH 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-06-28 23:03 ` [dpdk-dev] [PATCH 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-06-30 12:20 ` Nélio Laranjeiro
2017-06-28 23:04 ` [dpdk-dev] [PATCH 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-06-30 12:30 ` Nélio Laranjeiro
2017-06-30 12:43 ` Nélio Laranjeiro
2017-06-30 17:49 ` Yongseok Koh
2017-06-28 23:04 ` [dpdk-dev] [PATCH 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-06-30 13:01 ` Nélio Laranjeiro
2017-06-30 18:58 ` Yongseok Koh
2017-06-28 23:04 ` [dpdk-dev] [PATCH 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-06-30 13:02 ` Nélio Laranjeiro
2017-06-28 23:04 ` [dpdk-dev] [PATCH 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1 Yongseok Koh
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-07-03 13:48 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-07-03 13:58 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-07-03 14:06 ` Nélio Laranjeiro
2017-07-03 20:54 ` Yongseok Koh
2017-07-04 6:54 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-07-03 13:49 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1 Yongseok Koh
2017-07-03 23:54 ` Thomas Monjalon
2017-07-04 8:58 ` Nélio Laranjeiro
2017-07-05 0:38 ` Yongseok Koh
2017-07-05 8:21 ` Nélio Laranjeiro
2017-07-05 17:41 ` Yongseok Koh
2017-06-30 21:28 ` [dpdk-dev] [PATCH v2 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Bruce Richardson
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 " Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-07-06 7:17 ` Nélio Laranjeiro
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1 Yongseok Koh
2017-07-05 22:58 ` Yongseok Koh
2017-07-06 7:16 ` Nélio Laranjeiro
2017-07-06 9:58 ` Ferruh Yigit [this message]
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 5/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-07-07 9:58 ` [dpdk-dev] [PATCH v4 0/5] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3307161-7163-c212-69ed-cae0e7203b2e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).