From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org
Cc: ci@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v6 0/3] pmdinfogen: rewrite in Python
Date: Wed, 14 Oct 2020 16:37:56 +0200 [thread overview]
Message-ID: <b3880f4a-e075-2071-9337-74631864408b@redhat.com> (raw)
In-Reply-To: <20201004015947.9012-1-dmitry.kozliuk@gmail.com>
Hi Dmitry,
On 10/4/20 3:59 AM, Dmitry Kozlyuk wrote:
> This patchset implements existing pmdinfogen logic in Python, replaces
> and removes the old code. The goals of rewriting are:
>
> * easier maintenance by using a more high-level language,
> * simpler build process without host application and libelf,
> * foundation for adding Windows support.
>
> Travis CI script is adjusted to install python3-pyelftools, but other CI
> systems may need similar tweaking. Particularly, testing on FreeBSD and
> big-endian targets is desired.
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
> ---
> Changes in v6:
>
> 1. Address yapf and pylint warnings (Stephen Hemminger).
> 2. Add myself as new implementation maintainer (Thomas Monjalon).
>
> Dmitry Kozlyuk (3):
> pmdinfogen: add Python implementation
> build: use Python pmdinfogen
> pmdinfogen: remove C implementation
>
> .travis.yml | 2 +-
> MAINTAINERS | 3 +-
> buildtools/gen-pmdinfo-cfile.sh | 6 +-
> buildtools/meson.build | 1 +
> buildtools/pmdinfogen.py | 189 ++++++++++++
> buildtools/pmdinfogen/meson.build | 14 -
> buildtools/pmdinfogen/pmdinfogen.c | 456 -----------------------------
> buildtools/pmdinfogen/pmdinfogen.h | 119 --------
> doc/guides/linux_gsg/sys_reqs.rst | 6 +
> drivers/meson.build | 2 +-
> meson.build | 1 -
> 11 files changed, 203 insertions(+), 596 deletions(-)
> create mode 100755 buildtools/pmdinfogen.py
> delete mode 100644 buildtools/pmdinfogen/meson.build
> delete mode 100644 buildtools/pmdinfogen/pmdinfogen.c
> delete mode 100644 buildtools/pmdinfogen/pmdinfogen.h
>
Ninja fails when pyelftools is not installed.
Shouldn't meson detect and report it before build time?
Thanks,
Maxime
next prev parent reply other threads:[~2020-10-14 14:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200708212335.25338-1-dmitry.kozliuk@gmail.com>
[not found] ` <20200927214732.12783-1-dmitry.kozliuk@gmail.com>
2020-09-28 9:35 ` [dpdk-ci] [dpdk-dev] [PATCH v5 " David Marchand
2020-10-04 1:59 ` [dpdk-ci] [PATCH v6 " Dmitry Kozlyuk
2020-10-04 1:59 ` [dpdk-ci] [PATCH v6 1/3] pmdinfogen: add Python implementation Dmitry Kozlyuk
2020-10-04 1:59 ` [dpdk-ci] [PATCH v6 2/3] build: use Python pmdinfogen Dmitry Kozlyuk
2020-10-04 1:59 ` [dpdk-ci] [PATCH v6 3/3] pmdinfogen: remove C implementation Dmitry Kozlyuk
2020-10-14 14:37 ` Maxime Coquelin [this message]
2020-10-14 15:40 ` [dpdk-ci] [dpdk-dev] [PATCH v6 0/3] pmdinfogen: rewrite in Python Dmitry Kozlyuk
2020-10-14 18:31 ` [dpdk-ci] [PATCH v7 " Dmitry Kozlyuk
2020-10-14 18:31 ` [dpdk-ci] [PATCH v7 1/3] pmdinfogen: add Python implementation Dmitry Kozlyuk
2020-10-14 18:31 ` [dpdk-ci] [PATCH v7 2/3] build: use Python pmdinfogen Dmitry Kozlyuk
2020-10-14 18:31 ` [dpdk-ci] [PATCH v7 3/3] pmdinfogen: remove C implementation Dmitry Kozlyuk
2020-10-20 16:02 ` [dpdk-ci] [PATCH v7 0/3] pmdinfogen: rewrite in Python David Marchand
2020-10-20 17:45 ` Dmitry Kozlyuk
2020-10-20 22:09 ` Dmitry Kozlyuk
2020-10-20 17:44 ` [dpdk-ci] [PATCH v8 " Dmitry Kozlyuk
2020-10-20 17:44 ` [dpdk-ci] [PATCH v8 1/3] pmdinfogen: add Python implementation Dmitry Kozlyuk
2020-10-20 17:44 ` [dpdk-ci] [PATCH v8 2/3] build: use Python pmdinfogen Dmitry Kozlyuk
2020-10-21 9:00 ` Bruce Richardson
2021-01-20 0:05 ` [dpdk-ci] [dpdk-dev] " Thomas Monjalon
2021-01-20 7:23 ` Dmitry Kozlyuk
2020-10-20 17:44 ` [dpdk-ci] [PATCH v8 3/3] pmdinfogen: remove C implementation Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3880f4a-e075-2071-9337-74631864408b@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).