From: "Hunt, David" <david.hunt@intel.com>
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int
Date: Mon, 11 Dec 2017 10:43:04 +0000 [thread overview]
Message-ID: <b3b51919-c5eb-308a-9539-7f53ededf02e@intel.com> (raw)
In-Reply-To: <20171128132203.43181-1-marko.kovacevic@intel.com>
Hi Marko,
On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
--snip--
>
> int
> -guest_channel_host_connect(const char *path, unsigned lcore_id)
> +guest_channel_host_connect(const char *path, unsigned int lcore_id)
--snip--
I'd suggest adding the following into the commit message. It would help
explain why you're doing all the "unsigned" to "unsigned int" changes up
front rather than including them in the other patches.
"Since this patch-set attempts to clean up the power library, and there
are many instances of "unsigned" caught by checkpatch, it was decided to
clean these up first rather than have them included in the later patches
in the patch set. And would also minimise this type of error being
caught by checkpatch in the future."
Regards,
Dave.
next prev parent reply other threads:[~2017-12-11 10:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:22 Marko Kovacevic
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 2/4] power: clean up of acpi files Marko Kovacevic
2017-11-28 14:17 ` Bruce Richardson
2017-11-29 16:17 ` Marko Kovacevic
2017-12-11 10:44 ` Hunt, David
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 3/4] power: clean up of kvm files Marko Kovacevic
2017-12-11 10:45 ` Hunt, David
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 4/4] power: clean up of power common header Marko Kovacevic
2017-12-11 10:48 ` Hunt, David
2017-11-28 14:16 ` [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int Bruce Richardson
2017-11-29 16:15 ` Marko Kovacevic
2017-12-11 10:43 ` Hunt, David [this message]
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 " Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 2/4] power: clean up of power common header Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 3/4] power: clean up of acpi files Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 4/4] power: clean up of kvm files Marko Kovacevic
2018-01-11 23:14 ` [dpdk-dev] [PATCH v3 1/4] power: changed unsigned to unsigned int Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b51919-c5eb-308a-9539-7f53ededf02e@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).