From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Zhihong Wang <zhihong.wang@intel.com>, dev@dpdk.org
Cc: jianfeng.tan@intel.com, tiwei.bie@intel.com,
yliu@fridaylinux.org, cunming.liang@intel.com,
xiao.w.wang@intel.com, dan.daly@intel.com
Subject: Re: [dpdk-dev] [PATCH v5 0/5] vhost: support selective datapath
Date: Tue, 3 Apr 2018 10:27:31 +0200 [thread overview]
Message-ID: <b40105a0-b251-63ad-c8ea-1e6c6348bf82@redhat.com> (raw)
In-Reply-To: <20180402114656.17090-1-zhihong.wang@intel.com>
On 04/02/2018 01:46 PM, Zhihong Wang wrote:
> This patch set introduces support for selective datapath in DPDK vhost-user
> lib. vDPA stands for vhost Data Path Acceleration. The idea is to support
> virtio ring compatible devices to serve virtio driver directly to enable
> datapath acceleration.
>
> Design details
> ====
>
> A vDPA device is a virtio ring compatible backend. It's defined as follows:
>
> struct rte_vdpa_dev_addr {
> enum vdpa_addr_type type;
> union {
> uint8_t __dummy[64];
> struct rte_pci_addr pci_addr;
> };
> };
>
> struct rte_vdpa_dev_ops {
> /* Get capabilities of this device */
> int (*get_queue_num)(int did, uint32_t *queue_num);
> int (*get_features)(int did, uint64_t *features);
> int (*get_protocol_features)(int did, uint64_t *protocol_features);
>
> /* Driver configure/close the device */
> int (*dev_conf)(int vid);
> int (*dev_close)(int vid);
>
> /* Enable/disable this vring */
> int (*set_vring_state)(int vid, int vring, int state);
>
> /* Set features when changed */
> int (*set_features)(int vid);
>
> /* Destination operations when migration done */
> int (*migration_done)(int vid);
>
> /* Get the vfio group fd */
> int (*get_vfio_group_fd)(int vid);
>
> /* Get the vfio device fd */
> int (*get_vfio_device_fd)(int vid);
>
> /* Get the notify area info of the queue */
> int (*get_notify_area)(int vid, int qid,
> uint64_t *offset, uint64_t *size);
>
> /* Reserved for future extension */
> void *reserved[5];
> };
>
> struct rte_vdpa_device {
> struct rte_vdpa_dev_addr addr;
> struct rte_vdpa_dev_ops *ops;
> } __rte_cache_aligned;
>
>
> Changes to the current vhost-user lib are:
> ====
>
> 1. Make vhost device capabilities configurable to adopt various devices.
> Such capabilities include supported features, protocol features, queue
> number. APIs are introduced to configure these capabilities.
>
> 2. A set of device ops is defined for device specific operations:
>
> a. get_queue_num: Called to get supported queue number of the device.
>
> b. get_features: Called to get supported features of the device.
>
> c. get_protocol_features: Called to get supported protocol features of
> the device.
>
> d. dev_conf: Called to configure the actual device when the virtio
> device becomes ready.
>
> e. dev_close: Called to close the actual device when the virtio device
> is stopped.
>
> f. set_vring_state: Called to change the state of the vring in the
> actual device when vring state changes.
>
> g. set_features: Called to set the negotiated features to device.
>
> h. migration_done: Called to allow the device to response to RARP
> sending.
>
> i. get_vfio_group_fd: Called to get the VFIO group fd of the device.
>
> j. get_vfio_device_fd: Called to get the VFIO device fd of the device.
>
> k. get_notify_area: Called to get the notify area info of the queue.
>
> 3. To make vhost aware of its datapath type, an device id (did) is added
> into the vhost data structure to identify the actual device. APIs are
> introduced to configure it. When the default software datapath is used,
> did is set to -1. When alternative datapath is used, did should be set
> to specify which device to use, and each vhost-user socket can have
> only 1 connection in this case.
>
> Working process:
> ====
>
> 1. Register vDPA device with address and device ops, and get a did.
>
> 2. For vhost device creation:
>
> a. Register vhost-user socket.
>
> b. Set did of the vhost-user socket.
>
> c. Register vhost-user callbacks.
>
> d. Start to wait for connection.
>
> 3. When connection comes and virtio device data structure is negotiated,
> the device will be configured with all needed info.
>
> ---
> Changes in v5:
>
> 1. Rename the vDPA device ops to follow convention.
>
> 2. Rename APIs for better description.
>
> 3. Improve sanity check.
>
> ---
> Changes in v4:
>
> 1. Remove the "engine" concept in the lib.
>
> ---
> Changes in v3:
>
> 1. Keep macro names the same as in the spec.
>
> 2. Export new APIs where they're introduced.
>
> ---
> Changes in v2:
>
> 1. Ensure negotiated capabilities are supported in vhost-user lib.
>
> 2. Add APIs for live migration.
>
> 3. Configure the data path at the right time.
>
> 4. Add VFIO related vDPA device ops.
>
> 5. Rebase on dpdk-next-virtio.
>
> Zhihong Wang (5):
> vhost: export vhost feature definitions
> vhost: support selective datapath
> vhost: add apis for datapath configuration
> vhost: adapt vhost lib for selective datapath
> vhost: add apis for live migration
>
> lib/librte_vhost/Makefile | 4 +-
> lib/librte_vhost/rte_vdpa.h | 87 +++++++++++++++++
> lib/librte_vhost/rte_vhost.h | 154 ++++++++++++++++++++++++++++++
> lib/librte_vhost/rte_vhost_version.map | 16 ++++
> lib/librte_vhost/socket.c | 166 ++++++++++++++++++++++++++++++++-
> lib/librte_vhost/vdpa.c | 115 +++++++++++++++++++++++
> lib/librte_vhost/vhost.c | 105 +++++++++++++++++++++
> lib/librte_vhost/vhost.h | 14 ++-
> lib/librte_vhost/vhost_user.c | 70 +++++++++++++-
> lib/librte_vhost/vhost_user.h | 7 --
> 10 files changed, 718 insertions(+), 20 deletions(-)
> create mode 100644 lib/librte_vhost/rte_vdpa.h
> create mode 100644 lib/librte_vhost/vdpa.c
>
Series applied to dpdk-next-virtio/master.
Thanks!
Maxime
prev parent reply other threads:[~2018-04-03 8:27 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 23:28 [dpdk-dev] [PATCH 0/7] " Zhihong Wang
2018-02-02 23:28 ` [dpdk-dev] [PATCH 1/7] vhost: make capabilities configurable Zhihong Wang
2018-02-06 10:19 ` Maxime Coquelin
2018-02-08 3:03 ` Wang, Zhihong
2018-02-02 23:28 ` [dpdk-dev] [PATCH 2/7] vhost: export vhost feature definitions Zhihong Wang
2018-02-02 23:28 ` [dpdk-dev] [PATCH 3/7] vhost: support selective datapath Zhihong Wang
2018-02-02 23:28 ` [dpdk-dev] [PATCH 4/7] vhost: add apis for datapath configuration Zhihong Wang
2018-02-02 23:28 ` [dpdk-dev] [PATCH 5/7] vhost: adapt vhost lib for selective datapath Zhihong Wang
2018-02-02 23:28 ` [dpdk-dev] [PATCH 6/7] vhost: get callfd before device setup Zhihong Wang
2018-02-02 23:28 ` [dpdk-dev] [PATCH 7/7] vhost: export new apis Zhihong Wang
2018-03-05 9:20 ` [dpdk-dev] [PATCH v2 0/6] vhost: support selective datapath Zhihong Wang
2018-03-05 9:20 ` [dpdk-dev] [PATCH v2 1/6] vhost: export vhost feature definitions Zhihong Wang
2018-03-06 9:37 ` Tan, Jianfeng
2018-03-06 14:03 ` Maxime Coquelin
2018-03-15 10:58 ` Wang, Zhihong
2018-03-05 9:20 ` [dpdk-dev] [PATCH v2 2/6] vhost: support selective datapath Zhihong Wang
2018-03-05 9:20 ` [dpdk-dev] [PATCH v2 3/6] vhost: add apis for datapath configuration Zhihong Wang
2018-03-05 9:20 ` [dpdk-dev] [PATCH v2 5/6] vhost: add apis for live migration Zhihong Wang
2018-03-05 9:20 ` [dpdk-dev] [PATCH v2 4/6] vhost: adapt vhost lib for selective datapath Zhihong Wang
2018-03-05 9:20 ` [dpdk-dev] [PATCH v2 6/6] vhost: export new apis Zhihong Wang
2018-03-06 9:51 ` Tan, Jianfeng
2018-03-15 10:55 ` Wang, Zhihong
2018-03-19 10:12 ` [dpdk-dev] [PATCH v3 0/5] vhost: support selective datapath Zhihong Wang
2018-03-19 10:12 ` [dpdk-dev] [PATCH v3 1/5] vhost: export vhost feature definitions Zhihong Wang
2018-03-19 10:12 ` [dpdk-dev] [PATCH v3 2/5] vhost: support selective datapath Zhihong Wang
2018-03-21 21:05 ` Maxime Coquelin
2018-03-22 7:55 ` Wang, Zhihong
2018-03-22 8:31 ` Maxime Coquelin
2018-03-19 10:12 ` [dpdk-dev] [PATCH v3 3/5] vhost: add apis for datapath configuration Zhihong Wang
2018-03-21 21:08 ` Maxime Coquelin
2018-03-22 8:22 ` Wang, Zhihong
2018-03-22 14:18 ` Maxime Coquelin
2018-03-23 10:35 ` Wang, Zhihong
2018-03-19 10:12 ` [dpdk-dev] [PATCH v3 4/5] vhost: adapt vhost lib for selective datapath Zhihong Wang
2018-03-19 10:13 ` [dpdk-dev] [PATCH v3 5/5] vhost: add apis for live migration Zhihong Wang
2018-03-29 12:15 ` [dpdk-dev] [PATCH v3 0/5] vhost: support selective datapath Wodkowski, PawelX
2018-03-30 9:35 ` Wang, Zhihong
2018-03-30 10:00 ` [dpdk-dev] [PATCH v4 " Zhihong Wang
2018-03-30 10:00 ` [dpdk-dev] [PATCH v4 1/5] vhost: export vhost feature definitions Zhihong Wang
2018-03-31 5:56 ` Maxime Coquelin
2018-03-30 10:01 ` [dpdk-dev] [PATCH v4 2/5] vhost: support selective datapath Zhihong Wang
2018-03-31 6:10 ` Maxime Coquelin
2018-04-02 1:58 ` Wang, Zhihong
2018-03-31 7:38 ` Maxime Coquelin
2018-04-02 2:03 ` Wang, Zhihong
2018-03-30 10:01 ` [dpdk-dev] [PATCH v4 3/5] vhost: add apis for datapath configuration Zhihong Wang
2018-03-31 7:04 ` Maxime Coquelin
2018-04-02 2:01 ` Wang, Zhihong
2018-03-30 10:01 ` [dpdk-dev] [PATCH v4 4/5] vhost: adapt vhost lib for selective datapath Zhihong Wang
2018-03-31 7:35 ` Maxime Coquelin
2018-04-02 11:52 ` Wang, Zhihong
2018-03-30 10:01 ` [dpdk-dev] [PATCH v4 5/5] vhost: add apis for live migration Zhihong Wang
2018-03-31 7:39 ` Maxime Coquelin
2018-04-02 11:46 ` [dpdk-dev] [PATCH v5 0/5] vhost: support selective datapath Zhihong Wang
2018-04-02 11:46 ` [dpdk-dev] [PATCH v5 1/5] vhost: export vhost feature definitions Zhihong Wang
2018-04-02 11:46 ` [dpdk-dev] [PATCH v5 2/5] vhost: support selective datapath Zhihong Wang
2018-04-03 8:02 ` Maxime Coquelin
2018-04-15 17:39 ` Thomas Monjalon
2018-04-16 7:26 ` Maxime Coquelin
2018-04-03 8:19 ` Maxime Coquelin
2018-04-03 14:35 ` Wang, Zhihong
2018-04-02 11:46 ` [dpdk-dev] [PATCH v5 3/5] vhost: add apis for datapath configuration Zhihong Wang
2018-04-03 8:07 ` Maxime Coquelin
2018-04-02 11:46 ` [dpdk-dev] [PATCH v5 4/5] vhost: adapt vhost lib for selective datapath Zhihong Wang
2018-04-03 8:05 ` Maxime Coquelin
2018-04-02 11:46 ` [dpdk-dev] [PATCH v5 5/5] vhost: add apis for live migration Zhihong Wang
2018-04-03 8:27 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b40105a0-b251-63ad-c8ea-1e6c6348bf82@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yliu@fridaylinux.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).